You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/01/24 18:55:20 UTC
[GitHub] [helix] jiajunwang commented on a change in pull request #693:
Removed useless znodes to resolve dependency between test methods in
TestZKUtil
jiajunwang commented on a change in pull request #693: Removed useless znodes to resolve dependency between test methods in TestZKUtil
URL: https://github.com/apache/helix/pull/693#discussion_r370789642
##########
File path: helix-core/src/test/java/org/apache/helix/manager/zk/TestZKUtil.java
##########
@@ -63,6 +65,13 @@ public void afterClass() {
deleteCluster(clusterName);
}
+ @AfterMethod()
+ public void afterMethod() {
+ String path = PropertyPathBuilder.instanceConfig(clusterName);
+ _gZkClient.deleteRecursively(path);
+ _gZkClient.createPersistent(path);
Review comment:
I checked the test cases one by one, there is no test which is testing to create the root path (please correct me if I am wrong). Given so, re-create the root path is easier and safer.
If we really have a case that requires the root path non-exists, feel free to change that test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org