[GitHub] [activemq-artemis] franz1981 commented on pull request #3573: ARTEMIS-3292 PageSyncTimer can reduce garbage and sync while batching syncs

[GitBox <gi...@apache.org>]

franz1981 commented on pull request #3573:
URL: https://github.com/apache/activemq-artemis/pull/3573#issuecomment-914053249


   TLDR on this change (still need to run CI on this): 
   
   - lock-free sync requests (no interference with background sync):  it affects `PagingStoreImpl::page`, that's performing `sync` on
   ```java
               if (tx == null && syncNonTransactional && message.isDurable()) {
                  sync();
               }
   ```
   - performing background sync no longer allocate ` OperationContext[]`: it affects paging with fast disks ie with a very short page sync timeout
   
   No hurry to get it but I think is a nice improvement @clebertsuconic @michaelandrepearce wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org