[GitHub] [libcloud] Kami edited a comment on issue #1393: Fix wheel METADATA and ensure conditional dependencies are handled correctly

[GitBox <gi...@apache.org>]

Kami edited a comment on issue #1393: Fix wheel METADATA and ensure conditional dependencies are handled correctly
URL: https://github.com/apache/libcloud/pull/1393#issuecomment-568199665
 
 
   @arterrey I believe this should fix the issue you reported in #1392.
   
   I had quite some trouble testing it using ``buildout`` since latest version of buildout wheel plugin is broken and doesn't work with the latest version of ``wheel`` packages (so I couldn't test it using the locally build wheel from this branch).
   
   In the end, I got a bit creative and confirmed it's working by building an egg from this branch locally and using this ``buildout.cfg`` (both using Python 2.7 and Python 3):
   
   ```ini
   [buildout]
   parts = libcloud
   
   [libcloud]
   recipe = zc.recipe.egg
   eggs = apache-libcloud
   index =
   find-links = .
   ```
   
   ```bash
   rm -rf eggs/*
   python setup.py bdist_egg
   # For Python 3 venv
   cp dist/apache_libcloud-2.7.0-py3.6.egg eggs/ 
   # For Python 2 venv
   cp dist/apache_libcloud-2.7.0-py2.7.egg eggs/
   ```
   
   I confirmed it now doesn't try to download typing and enum34 packages when using Python >= 3.4.0 (and it tries to download them when using Python 2.7).
   
   Having said that, I would also appreciate if you could confirm the fix as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services