You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/11/17 14:39:37 UTC
Review Request 63916: YARN, MapReduce2, Hive,
and Oozie Should Conditionally Install LZO
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63916/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
Bugs: AMBARI-22467
https://issues.apache.org/jira/browse/AMBARI-22467
Repository: ambari
Description
-------
Changes Summary:
- Do not install lzo if GPL license if not accepted, instead give out logger.warning and skip
- Remove installation of lzo from metainfo.xml. Since we need to install lzo on restart if lzo is enabled/license accepted, we still need to do this in Python code. No need to duplicate.
Clients will also use that code during install.
- Move function get_lzo_packages to lzo_utils.py
- Add code for Yarn, MR2, Hive to install lzo, edit existing code to install lzo for HDFS,Oozie to use lzo_utils.py
Notes:
- Impl is Patch Upgrade friendly as uses the same code to detect {stack_version} as all the other packages. That code (not implemented here) gets version depending component specific repo info not stack specific.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/__init__.py f144b2da32
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py cfbb7d81e8
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 31e78b9e60
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 2df1b9f647
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 6f702d3616
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py fe488c3004
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 5ca012b796
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py abbe59ed9f
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 7d22603184
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py cd1f7ad36f
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py f6e8391a54
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 07a9ef8e94
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 63e85e363f
ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3
Diff: https://reviews.apache.org/r/63916/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk