[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

["rreddy-22 (via GitHub)" <gi...@apache.org>]

rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269665264


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java:
##########
@@ -52,33 +42,22 @@ public Map<String, AssignmentMemberSpec> members() {
         return members;
     }
 
-    /**
-     * @return Topic metadata keyed by topic Ids.
-     */
-    public Map<Uuid, AssignmentTopicMetadata> topics() {
-        return topics;
-    }
-
     @Override
     public boolean equals(Object o) {
         if (this == o) return true;
-        if (o == null || getClass() != o.getClass()) return false;
+        if (!(o instanceof AssignmentSpec)) return false;

Review Comment:
   Sry I just auto-generated these functions, is there a reason why one is better than the other?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org