You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/08/22 20:26:25 UTC
Review Request 13743: Added a re-registration time for slaves.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13743/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
This is a split up of https://reviews.apache.org/r/13699/ (has ship its) into two commits.
With slave recovery, this proves useful for seeing when slaves have re-registered with the master.
Diffs
-----
src/master/http.cpp 1ac84a9f75df43632ddbd1fec50333c159651f15
src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d
src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
src/webui/master/static/slaves.html 15877b7069a11b9feda58be313620f94624a62ea
Diff: https://reviews.apache.org/r/13743/diff/
Testing
-------
make check + manual webui testing
Thanks,
Ben Mahler
Re: Review Request 13743: Added a re-registration time for slaves.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13743/#review25491
-----------------------------------------------------------
Ship it!
mark as submitted?
- Vinod Kone
On Aug. 22, 2013, 6:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13743/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 6:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a split up of https://reviews.apache.org/r/13699/ (has ship its) into two commits.
>
> With slave recovery, this proves useful for seeing when slaves have re-registered with the master.
>
>
> Diffs
> -----
>
> src/master/http.cpp 1ac84a9f75df43632ddbd1fec50333c159651f15
> src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d
> src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
> src/webui/master/static/slaves.html 15877b7069a11b9feda58be313620f94624a62ea
>
> Diff: https://reviews.apache.org/r/13743/diff/
>
>
> Testing
> -------
>
> make check + manual webui testing
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13743: Added a re-registration time for slaves.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13743/#review25423
-----------------------------------------------------------
Ship it!
This is indeed useful!
- Brenden Matthews
On Aug. 22, 2013, 6:26 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13743/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 6:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is a split up of https://reviews.apache.org/r/13699/ (has ship its) into two commits.
>
> With slave recovery, this proves useful for seeing when slaves have re-registered with the master.
>
>
> Diffs
> -----
>
> src/master/http.cpp 1ac84a9f75df43632ddbd1fec50333c159651f15
> src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d
> src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
> src/webui/master/static/slaves.html 15877b7069a11b9feda58be313620f94624a62ea
>
> Diff: https://reviews.apache.org/r/13743/diff/
>
>
> Testing
> -------
>
> make check + manual webui testing
>
>
> Thanks,
>
> Ben Mahler
>
>