You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "letian-jiang (via GitHub)" <gi...@apache.org> on 2024/12/26 08:50:21 UTC
[PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
letian-jiang opened a new pull request, #2967:
URL: https://github.com/apache/drill/pull/2967
Bump zookeeper to 3.9.3
https://issues.apache.org/jira/browse/DRILL-8514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre closed pull request #2967: DRILL-8514: Bump zookeeper to 3.9.3
URL: https://github.com/apache/drill/pull/2967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-3222009751
Replaced by DRILL-8531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2567219162
@pjfanning @letian-jiang All the other dependency libraries have been updated. Please rebase on current master and let's see if we can get this working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2568786827
I think we should delay this and instead concentrate on upgrading the version of Phoenix that we use. The newer version of Phoenix seems to use newer HBase and Zookeeper versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "letian-jiang (via GitHub)" <gi...@apache.org>.
letian-jiang commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2579365349
Thanks for the advice. I will try this in the comming weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2568773793
The test issues seem related to the zookeeper upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "letian-jiang (via GitHub)" <gi...@apache.org>.
letian-jiang closed pull request #2967: DRILL-8514: Bump zookeeper to 3.9.3
URL: https://github.com/apache/drill/pull/2967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2562983116
I created #2968 - maybe we can hold off with zookeeper upgrade until we know if that can be merged ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2567516463
The hadoop-2 build failure was because this setting is too small
```
<jdbc-all-jar.maxsize>55000000</jdbc-all-jar.maxsize>
```
Could you change it to this?
```
<jdbc-all-jar.maxsize>56000000</jdbc-all-jar.maxsize>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2852880243
@pjfanning @letian-jiang
We might be able to complete this PR once https://github.com/apache/drill/pull/2987 gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2562809175
@letian-jiang Why don't you try also updating the HBase client? Drill is currently running version 2.5 and there is a newer version available on MavenCentral.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2573688265
I don't know much about Phoenix and upgrading its version is not straightforward - https://github.com/apache/drill/pull/2972
Another option here is to look at shading the zookeeper classes and including those in one of the Drill jars so that we can upgrade the zookeeper version used by the Drill code but not affect the version used by Phoenix plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2740600684
@letian-jiang Are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2853827967
The issue is more about Apache Phoenix and it relying on an old version of zookeeper. Unless they do a release that upgrades zookeeper then we are stuck with having to look at shading the zookeeper jar that we use in Drill code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "letian-jiang (via GitHub)" <gi...@apache.org>.
letian-jiang commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2567244169
@cgivre Done. Could you rerun the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2573696670
I think the shading option would work. If someone is using Phoenix and runs into issues we can revisit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2562434681
Upgrading zookeeper is not that easy. The CI build has already failed with an issue around protobuf.
This is a recent attempt to upgrade - #2893
That attempt had to raise the limit on the jar sizes and still hit test issues with HBase testing. It may not be feasible to upgrade Zookeeper until HBase and maybe other dependencies of Drill have uptaken newer versions of Zookeeper themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "letian-jiang (via GitHub)" <gi...@apache.org>.
letian-jiang commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2568616867
Error: Errors:
Error: PhoenixTestSuite.initPhoenix:54 » Runtime Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterKeeperErrorCode = ConnectionLoss for /hbase
Error: SecuredPhoenixTestSuite.initPhoenix:55 » Runtime Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterKeeperErrorCode = ConnectionLoss for /hbase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "letian-jiang (via GitHub)" <gi...@apache.org>.
letian-jiang commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2562496736
> Upgrading zookeeper is not that easy. The CI build has already failed with an issue around protobuf. This is a recent attempt to upgrade - #2893 That attempt had to raise the limit on the jar sizes and still hit test issues with HBase testing. It may not be feasible to upgrade Zookeeper until HBase and maybe other dependencies of Drill have uptaken newer versions of Zookeeper themselves.
Ok. Thanks for the information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "letian-jiang (via GitHub)" <gi...@apache.org>.
letian-jiang commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2568713137
@pjfanning @cgivre Is it ok to simply rerun the CI again? This maybe an accidental error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8514: Bump zookeeper to 3.9.3 (drill)
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2967:
URL: https://github.com/apache/drill/pull/2967#issuecomment-2853925631
It might be better if Drill advices people to keep their zookeeper installs protected from the public internet or untrusted users by using network allow lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org