You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/03/17 15:35:00 UTC
[jira] [Commented] (SOLR-11891) DocsStreamer populates SolrDocument
w/unnecessary fields
[ https://issues.apache.org/jira/browse/SOLR-11891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403487#comment-16403487 ]
David Smiley commented on SOLR-11891:
-------------------------------------
Nice thorough job hoss.
One little Q: in {{convertLuceneDocToSolrDoc()}} (3 arg version), wouldn't it be simpler/clearer to remove the outer {{if (null == fieldNamesNeeded)}} and instead guard the fieldNamesNeeded.contains call with fieldNamesNeeded == null || .... ? At least I think so but no big deal.
> DocsStreamer populates SolrDocument w/unnecessary fields
> --------------------------------------------------------
>
> Key: SOLR-11891
> URL: https://issues.apache.org/jira/browse/SOLR-11891
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
> Affects Versions: 5.4, 6.4.2, 6.6.2
> Reporter: wei wang
> Assignee: Hoss Man
> Priority: Major
> Attachments: DocsStreamer.java.diff, SOLR-11891.patch, SOLR-11891.patch.BAD
>
>
> We observe that solr query time increases significantly with the number of rows requested, even all we retrieve for each document is just fl=id,score. Debugged a bit and see that most of the increased time was spent in BinaryResponseWriter, converting lucene document into SolrDocument. Inside convertLuceneDocToSolrDoc():
> [https://github.com/apache/lucene-solr/blob/df874432b9a17b547acb24a01d3491839e6a6b69/solr/core/src/java/org/apache/solr/response/DocsStreamer.java#L182]
> I am a bit puzzled why we need to iterate through all the fields in the document. Why can’t we just iterate through the requested field list?
> [https://github.com/apache/lucene-solr/blob/df874432b9a17b547acb24a01d3491839e6a6b69/solr/core/src/java/org/apache/solr/response/DocsStreamer.java#L156]
> e.g. when pass in the field list as
> sdoc = convertLuceneDocToSolrDoc(doc, rctx.getSearcher().getSchema(), fnames)
> and just iterate through fnames, there is a significant performance boost in our case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org