You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/02/14 01:42:29 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1618: Upgrading to Spring Boot 2.4.2
ptuomola opened a new pull request #1618:
URL: https://github.com/apache/fineract/pull/1618
## Description
Upgrade to Spring Boot 2.4.2 - the Renovate PR does not work due to deprecated methods
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1618: Upgrading to Spring Boot 2.4.2
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1618:
URL: https://github.com/apache/fineract/pull/1618#issuecomment-779826372
Ok this looks to be a bit trickier than I expected, as it also upgrades Spring Security - which in turn doesn't seem to be compatible with our use of Oauth. Will need to look at this again later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1618: Upgrading to Spring Boot 2.4.2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1618:
URL: https://github.com/apache/fineract/pull/1618#issuecomment-802417513
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1618: Upgrading to Spring Boot 2.4.2
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1618:
URL: https://github.com/apache/fineract/pull/1618#issuecomment-779028511
I think there's something wrong with my PR so please do not merge this.
Still need to find a way to reproduce this issue locally and then I can
fix.
On Mon, Feb 15, 2021, 14:49 Awasum Yannick <no...@github.com> wrote:
> Reopened #1618 <https://github.com/apache/fineract/pull/1618>.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1618#event-4330060169>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASJVCSF62PX6A3NTFKQBXLS7C7X7ANCNFSM4XSW35YQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1618: Upgrading to Spring Boot 2.4.2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1618:
URL: https://github.com/apache/fineract/pull/1618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1618: Upgrading to Spring Boot 2.4.2
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1618:
URL: https://github.com/apache/fineract/pull/1618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org