[GitHub] [airflow] uranusjr commented on a change in pull request #19487: Fix task instance api cannot list task instances with None state

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #19487:
URL: https://github.com/apache/airflow/pull/19487#discussion_r747311902



##########
File path: airflow/api_connexion/endpoints/task_instance_endpoint.py
##########
@@ -73,9 +74,22 @@ def get_task_instance(dag_id: str, dag_run_id: str, task_id: str, session=None):
     return task_instance_schema.dump(task_instance)
 
 
+def _convert_state(states):
+    if not states:
+        return
+    for idx, item in enumerate(states):
+        # we do not support 'null' maybe we should?
+        # to support null, we should add it to TaskState in
+        # openapi doc

Review comment:
       Why though? The state is called `NONE` and the Python counterpart is `None`. I don’t think we use `null` anywhere in the public API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org