You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by "William Lieurance (JIRA)" <ji...@apache.org> on 2018/02/01 20:14:00 UTC
[jira] [Created] (TAMAYA-327) Inconsistent signature for creating
ConversionContext
William Lieurance created TAMAYA-327:
----------------------------------------
Summary: Inconsistent signature for creating ConversionContext
Key: TAMAYA-327
URL: https://issues.apache.org/jira/browse/TAMAYA-327
Project: Tamaya
Issue Type: Bug
Reporter: William Lieurance
During some additional testing in the API added as part of TAMAYA-288, I came across an inconsistency between the ConversionContext and the ConversionContext.Builder. Namely, the comments say that supportedFormats have their order maintained, which is consistent with the use of an ArrayList here [https://github.com/apache/incubator-tamaya/blob/master/code/api/src/main/java/org/apache/tamaya/spi/ConversionContext.java#L42] . The builder, however implements the same supportedFormats with a HashSet, which does not ensure order. See [https://github.com/apache/incubator-tamaya/blob/master/code/api/src/main/java/org/apache/tamaya/spi/ConversionContext.java#L148] .
I'm planning on creating a pull request with the additional tests for that object as well as a patch to more consistently maintain order (all ArrayLists). Please let me know if the better answer is to more consistently leave order unspecified (all HashSets).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)