You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "enesyesil (via GitHub)" <gi...@apache.org> on 2025/11/02 20:44:19 UTC
[PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
enesyesil opened a new pull request, #14481:
URL: https://github.com/apache/iceberg/pull/14481
… nav
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "enesyesil (via GitHub)" <gi...@apache.org>.
enesyesil commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3488514949
Hi, I just pushed the latest changes. the File I/O link was added under the api section, other links also updated. Please have a look when you get a chance, and let me know if I should adjust anything else. Thanks a lot for the help and feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "enesyesil (via GitHub)" <gi...@apache.org>.
enesyesil commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3500623081
<img width="1509" height="814" alt="Screenshot 2025-11-06 at 11 09 54 PM" src="https://github.com/user-attachments/assets/afbd21ce-abb2-4e98-b2c2-b1b974d1a863" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#discussion_r2485142481
##########
site/nav.yml:
##########
@@ -100,8 +61,15 @@ nav:
- Sponsors: https://www.apache.org/foundation/sponsors.html
- Community:
- Community: community.md
+ - Blogs: blogs.md
- Talks: talks.md
- Vendors: vendors.md
+
+ - About: about.md
+ - Benchmarks: benchmarks.md
+ - File I/O: fileio.md
+ - Security: security.md
+
- Specification:
- Terms: terms.md
- REST Catalog Spec: rest-catalog-spec.md
Review Comment:
I don't think we want to put these links in the root navigation. You can refer to https://github.com/apache/iceberg/pull/14399#issuecomment-3434776310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#discussion_r2500450771
##########
docs/mkdocs.yml:
##########
@@ -38,6 +38,7 @@ nav:
- API:
- Quickstart: java-api-quickstart.md
- API: api.md
+ - File I/O: ../../fileio/
Review Comment:
weird thing i noticed while rendering this locally.
api.md / https://iceberg.apache.org/docs/nightly/api/
has a side bar
but fileio does not.
i didnt see where this is controlled but would be good to keep the consistency here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3478636416
Thanks for working on this.
You can run `make serve` in the `site/` dir to render the site locally so that we can preview the changes.
We should also figure out where best to places these links within the nav
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "enesyesil (via GitHub)" <gi...@apache.org>.
enesyesil commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3512994669
Thanks @ebyhr and @kevinjqliu for the review and feedback. Really appreciate the support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3512928186
Thanks for the PR @enesyesil and thanks for the review @ebyhr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #14481:
URL: https://github.com/apache/iceberg/pull/14481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "enesyesil (via GitHub)" <gi...@apache.org>.
enesyesil commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3499370338
Hi, yeah I guess the reason is that MkDocs builds from the docs/ directory, so linking with ../../fileio/ jumps outside the build and loses the sidebar context.
Do you think it would be better to move the fileio docs into docs/, or just mirror them there to keep consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "enesyesil (via GitHub)" <gi...@apache.org>.
enesyesil commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3483276217
Thanks for the feedback.
I also noticed in #14399
that suggested the following structure:
“FileIO could go under the API section, About can be removed, and the rest can be moved into the Project tab.”
Before I make any further updates, could you please confirm if this layout is preferred? and I will also include a screenshot of updated nav layout in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3483339101
I think FileIO under API makes sense
- https://iceberg.apache.org/fileio/
- https://iceberg.apache.org/docs/nightly/api/
We can get rid of About, the same paragraph is on the homepage
- https://iceberg.apache.org/about/
Benchmark and Security in the project tab also makes sense
- https://iceberg.apache.org/contribute/
- https://iceberg.apache.org/benchmarks/
- https://iceberg.apache.org/security/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: add missing pages (about, benchmarks, fileio, security) to site… [iceberg]
Posted by "enesyesil (via GitHub)" <gi...@apache.org>.
enesyesil commented on PR #14481:
URL: https://github.com/apache/iceberg/pull/14481#issuecomment-3505378723
Sorry for the delay. File I/O now appears under the API section with the sidebar showing correctly, I verified locally.
Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org