You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Koushik Das <ko...@citrix.com> on 2013/04/01 09:41:14 UTC
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review18578
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java
<https://reviews.apache.org/r/9779/#comment38959>
What it means to restore from new iso? Do we need a new iso parameter?
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9779/#comment38963>
Handling of iso case is not clear. Are you expecting the iso id in the newTemplateId parameter?
- Koushik Das
On March 6, 2013, 12:23 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 12:23 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
>
>
> This addresses bug CLOUDSTACK-1453.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
> server/src/com/cloud/vm/UserVmManagerImpl.java ca9c13f
>
> Diff: https://reviews.apache.org/r/9779/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On April 1, 2013, 7:41 a.m., Koushik Das wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3884
> > <https://reviews.apache.org/r/9779/diff/1/?file=267170#file267170line3884>
> >
> > Handling of iso case is not clear. Are you expecting the iso id in the newTemplateId parameter?
Now we have common API parameter id that takes either template ID or ISO ID. So in the restoreVMInternal method "newTemplateId" can be either template/ISO id, we handle it accordingly in the code.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review18578
-----------------------------------------------------------
On May 24, 2013, 5:52 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
>
> (Updated May 24, 2013, 5:52 a.m.)
>
>
> Review request for cloudstack, Nitin Mehta and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
>
>
> This addresses bug CLOUDSTACK-1453.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
> server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a
> server/test/com/cloud/vm/UserVmManagerTest.java 6a97114
>
> Diff: https://reviews.apache.org/r/9779/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>