You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/07 02:34:35 UTC
[GitHub] [incubator-eventmesh] MajorHe1 commented on a diff in pull request #2472: [ISSUE #2471] use log instead of print when exception occurred in EventMeshMessageTCPSubClient
MajorHe1 commented on code in PR #2472:
URL: https://github.com/apache/incubator-eventmesh/pull/2472#discussion_r1041691055
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java:
##########
@@ -126,7 +126,7 @@ public void close() {
try {
super.close();
} catch (Exception ex) {
- ex.printStackTrace();
+ log.warn("exception occurred when close.", ex);
Review Comment:
log is generated by lombokļ¼ already change warn to error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org