You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "kenhuuu (via GitHub)" <gi...@apache.org> on 2025/10/20 16:05:54 UTC

[PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

kenhuuu opened a new pull request, #3246:
URL: https://github.com/apache/tinkerpop/pull/3246

   Local was behaving as a per traverser traversal when it should be a per object traversal. This means that there should be no bulked traversers that are added as starts to local traversals.
   
   https://issues.apache.org/jira/browse/TINKERPOP-3196
   
   <!--
   Thanks for contributing! Reminders:
   + TARGET the earliest branch where you want the change
       3.7-dev -> 3.7.5 (non-breaking only)
       3.8-dev -> 3.8.0
       master  -> 4.0.0
   + Committers will MERGE the PR forward to newer versions
   + ADD entry to the CHANGELOG.asciidoc for the targeted version
       Do not reference a JIRA number there
   + ADD JIRA number to title and link in description
   + PRs requires 3 +1s from committers OR
                  1 +1 and 7 day wait to merge.
   + MORE details: https://s.apache.org/rtnal
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#discussion_r2457184490


##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -319,6 +319,34 @@ This is a breaking change for .NET applications that rely on byte values. Existi
 
 See: link:https://issues.apache.org/jira/browse/TINKERPOP-3161[TINKERPOP-3161]
 
+==== Split bulked traversers for `local()`
+
+Prior to 3.8.0, the `local()` exhibited "traverser-local" semantics, where the local traversal would independently to
+each individual Traverser. This often led to confusion, especially in the presence of reducing barrier steps as the
+presence of bulked traversers would lead to multiple objects being processed at once. `local()` has been updated to
+automatically split any bulked traversers and thus now exhibits true "object-local" semantics.

Review Comment:
   ```suggestion
   Prior to 3.8.0, local() exhibited "traverser-local" semantics, where the local traversal would apply independently to each individual 
   Traverser. This often led to confusion, especially in the presence of reducing barrier steps, as bulked traversers would cause multiple 
   objects to be processed at once. local() has been updated to automatically split any bulked traversers and thus now exhibits true 
   "object-local" semantics.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#issuecomment-3445331099

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#issuecomment-3424875481

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#discussion_r2461319697


##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/branch/Local.feature:
##########
@@ -183,4 +183,91 @@ Feature: Step - local()
       | m[{"name":"marko","project":"lop"}]   |
       | m[{"name":"josh","project":"lop"}]    |
       | m[{"name":"peter","project":"lop"}]   |
-      | m[{"name":"josh","project":"ripple"}] |
\ No newline at end of file
+      | m[{"name":"josh","project":"ripple"}] |
+

Review Comment:
   Can you add a `local(aggregate())` or `local(groupCount())` test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#discussion_r2466752491


##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -457,6 +425,34 @@ compatibility.
 
 See: link:https://issues.apache.org/jira/browse/TINKERPOP-3161[TINKERPOP-3161]
 
+==== Split bulked traversers for `local()`
+
+Prior to 3.8.0, local() exhibited "traverser-local" semantics, where the local traversal would apply independently to
+each individual `Traverser`. This often led to confusion, especially in the presence of reducing barrier steps, as

Review Comment:
   Sentence is a little confusing. Just a suggestion to make it hopefully more clear:
   
   ```suggestion
   each individual bulkable `Traverser`. This often led to confusion, especially in the presence of reducing barrier steps, as
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#issuecomment-3453562940

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#discussion_r2466810180


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/LocalStep.java:
##########


Review Comment:
   Should the `currentStart` be reset here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu merged PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#issuecomment-3453475630

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#discussion_r2466752491


##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -457,6 +425,34 @@ compatibility.
 
 See: link:https://issues.apache.org/jira/browse/TINKERPOP-3161[TINKERPOP-3161]
 
+==== Split bulked traversers for `local()`
+
+Prior to 3.8.0, local() exhibited "traverser-local" semantics, where the local traversal would apply independently to
+each individual `Traverser`. This often led to confusion, especially in the presence of reducing barrier steps, as

Review Comment:
   ```suggestion
   each individual bulkable `Traverser`. This often led to confusion, especially in the presence of reducing barrier steps, as
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-3196 Split bulked traversers for LocalStep [tinkerpop]

Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on code in PR #3246:
URL: https://github.com/apache/tinkerpop/pull/3246#discussion_r2467088343


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/LocalStep.java:
##########


Review Comment:
   yes, it should. Thanks for noticing that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org