[GitHub] [hive] ayushtkn commented on a change in pull request #2890: HIVE-25819: Track event id on target cluster with respect to source cluster.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #2890:
URL: https://github.com/apache/hive/pull/2890#discussion_r795331875



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/OptimisedBootstrapUtils.java
##########
@@ -87,20 +88,20 @@ public static boolean checkFileExists(Path dumpPath, HiveConf conf, String fileN
   }
 
   /**
-   * Gets the event id from the event ack file
+   * Gets the source & target event id  from the event ack file
    * @param dumpPath the dump path
    * @param conf the hive configuration
    * @return the event id from file.
    * @throws IOException
    */
-  public static String getEventIdFromFile(Path dumpPath, HiveConf conf) throws IOException {
+  public static String[] getEventIdFromFile(Path dumpPath, HiveConf conf) throws IOException {

Review comment:
       It would be always 2, one from the source & one with respect to the target.
   The javadoc says that above.
   ```
   Gets the source & target event id  from the event ack file
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org