You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2018/04/10 19:50:21 UTC

[GitHub] storm pull request #2629: [STORM-3023] fix the issue that Storm UI not showi...

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2629

    [STORM-3023] fix the issue that Storm UI not showing correct values for component CPU, Memory and Executors

    https://issues.apache.org/jira/browse/STORM-3023
    
    (1) The component page of the UI is showing a blank for requested resources (CPU and Memory).
    (2) for the topology page what is being showed for them is the total for the entire topology, not individual components.
    
    It's because the storm rest api code is using wrong keys. The component `requestedMemOnHeap` is null and then the `Mustache` in ui code uses `requestedMemOnHeap` from the parent (which is the total sum)
    
    
    (3) And the executors of components in topology page shows wrong numbers. 
    This is a bug introduced when porting clojure to java https://github.com/apache/storm/pull/1147
    The number of executors of components gets accumulated incorrectly 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-3023

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2629
    
----
commit a50c2b145e6403447aa6d7e4b74b80e80171b5d9
Author: Ethan Li <et...@...>
Date:   2018-04-09T23:16:41Z

    [STORM-3023] fix the issue that Storm UI not showing correct values for component CPU, Memory and Executors

----


---

[GitHub] storm issue #2629: [STORM-3023] fix the issue that Storm UI not showing corr...

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2629
  
    Tested manually.
    
    Topology page:
    
    ![screen shot 2018-04-10 at 2 36 44 pm](https://user-images.githubusercontent.com/14900612/38580043-881b328a-3cce-11e8-9dfd-b41c77820748.png)
    
    Component page:
    ![screen shot 2018-04-10 at 2 51 07 pm](https://user-images.githubusercontent.com/14900612/38580071-9e33280c-3cce-11e8-82ca-a488e58cb00a.png)



---

[GitHub] storm pull request #2629: [STORM-3023] fix the issue that Storm UI not showi...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2629


---