You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by jzonthemtn <gi...@git.apache.org> on 2017/07/31 23:40:33 UTC

[GitHub] nifi pull request #2043: rNIFI-4248: Adding Rya processor.

GitHub user jzonthemtn opened a pull request:

    https://github.com/apache/nifi/pull/2043

    rNIFI-4248: Adding Rya processor.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jzonthemtn/nifi NIFI-4248

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2043.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2043
    
----
commit 22a82dd8d9ec3d5cab0bafe19ab92b928fb1ba0d
Author: jzonthemtn <je...@mtnfog.com>
Date:   2017-07-31T23:36:36Z

    NIFI-4248: Adding Rya processor.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2043: NIFI-4248: Adding Rya processor.

Posted by bbende <gi...@git.apache.org>.

Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/2043
  
    @jzonthemtn sounds good, if you find that InvokeHttp doesn't work for some reason, or if there is some specific logic related to Rya that you need, then by all means re-open


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2043: NIFI-4248: Adding Rya processor.

Posted by bbende <gi...@git.apache.org>.

Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/2043
  
    Hi @jzonthemtn , thanks for contributing... 
    
    I don't really know much about Apache Rya, other than the high-level description, but I was glancing over this PR... since PutRya is assuming the triples were created upstream, is there a reason the InvokeHttp processor couldn't be used to POST them to Rya?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #2043: NIFI-4248: Adding Rya processor.

Posted by jzonthemtn <gi...@git.apache.org>.

Github user jzonthemtn closed the pull request at:

    https://github.com/apache/nifi/pull/2043


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2043: NIFI-4248: Adding Rya processor.

Posted by jzonthemtn <gi...@git.apache.org>.

Github user jzonthemtn commented on the issue:

    https://github.com/apache/nifi/pull/2043
  
    @bbende There appears to be no reason why not! (Other than ignorance on my part.) I will test it but I think it will be fine so I'm going to close this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---