[GitHub] [helix] qqu0127 commented on a diff in pull request #2339: Implement data change listener for ZkMetaClient and test

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2339:
URL: https://github.com/apache/helix/pull/2339#discussion_r1080573661


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -2489,7 +2489,7 @@ public Object call() throws Exception {
     });
   }
 
-  protected void connect(final long maxMsToWaitUntilConnected)
+  public void connect(final long maxMsToWaitUntilConnected)

Review Comment:
   You are right, this should have been public in the first place. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org