You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2016/12/20 12:44:58 UTC
[jira] [Comment Edited] (SOLR-7115) UpdateLog can miss closing
transaction log objects.
[ https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764127#comment-15764127 ]
Yonik Seeley edited comment on SOLR-7115 at 12/20/16 12:44 PM:
---------------------------------------------------------------
I thought about that... but calling postCommit assumes a new searcher has been opened, so it doesn't seem right.
It seems like we should have explicit failure callbacks... commitFailed and openSearcherFailed (or add a boolean "success" flag to the post methods)?
was (Author: yseeley@gmail.com):
I thought about that... but calling postCommit assumes a new searcher has been opened, so it doesn't seem right.
It seems like we should have explicit failure callbacks... commitFailed and openSearcherFailed?
> UpdateLog can miss closing transaction log objects.
> ---------------------------------------------------
>
> Key: SOLR-7115
> URL: https://issues.apache.org/jira/browse/SOLR-7115
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Yonik Seeley
> Fix For: 6.x, master (7.0)
>
> Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt, SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt
>
>
> I've seen this happen on YourKit and in various tests - especially since adding resource release tracking to the log objects. Now I've got a test that catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it because we are going to overwrite prevTlog with a new log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org