You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/06/16 08:49:51 UTC
[PR] chore: add missing write permission to push built Docker images [arrow-swift]
kou opened a new pull request, #38:
URL: https://github.com/apache/arrow-swift/pull/38
## What's Changed
Override permission in the `docker` job.
Closes #37.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2978270420
> `github.actor` afaik would be `kou` (for this PR) but the required login would be `apache` which you can get through `github.repository_owner`
Hmm. Auto-generated GitHub Token may be for `github.actor` not `github.repository`.
FYI: ADBC uses `github.actor` and it works:
https://github.com/apache/arrow-adbc/blob/24950853d2398fd75601656fbf2bc2ddeff7d87c/.github/workflows/packaging.yml#L360-L365
https://github.com/apache/arrow-adbc/actions/runs/15668872626/job/44136690901#step:8:1
```text
Run docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772
with:
registry: ghcr.io
username: lidavidm
password: ***
ecr: auto
logout: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2978614344
https://github.com/apache/arrow-swift/pkgs/container/arrow-swift-dev is public. It must be available from forks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2978282514
> Alternatively we might need to ask infra to enable the package permissions for this repo? But I feel like that defaults to enabled.
https://github.com/apache/arrow-java/issues/476 may be related but let's try with this. If we can't push, let's ask INFRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#discussion_r2150702371
##########
.github/workflows/test.yaml:
##########
@@ -59,6 +59,8 @@ jobs:
name: Ubuntu Swift 5.10
runs-on: ubuntu-latest
timeout-minutes: 10
+ permissions:
+ contents: write
Review Comment:
```suggestion
packages: write
```
https://docs.github.com/en/packages/learn-github-packages/about-permissions-for-github-packages#about-scopes-and-permissions-for-package-registries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2978613661
Worked: https://github.com/apache/arrow-swift/actions/runs/15693333885/job/44213242144#step:9:849
```text
Pushing ghcr.io/apache/arrow-swift-dev:amd64-ubuntu-noble: c8ed27d1ec99 Pushed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#discussion_r2150949434
##########
.github/workflows/test.yaml:
##########
@@ -59,6 +59,8 @@ jobs:
name: Ubuntu Swift 5.10
runs-on: ubuntu-latest
timeout-minutes: 10
+ permissions:
+ contents: write
Review Comment:
Oh, sorry. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2975851457
apache/arrow uses Docker Hub not ghcr.io and Docker Hub user account is here: https://github.com/apache/arrow/blob/a974df4f2f11cf404c88df083d74a71aa463cfb9/.github/workflows/cpp.yml#L154-L155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #38:
URL: https://github.com/apache/arrow-swift/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2978333275
Ah, ok! Then it's probably just the missing scope :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: add missing write permission to push built Docker images [arrow-swift]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #38:
URL: https://github.com/apache/arrow-swift/pull/38#issuecomment-2977836469
Alternatively we might need to ask infra to enable the package permissions for this repo? But I feel like that defaults to enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org