You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/02/16 07:56:22 UTC
[GitHub] [zeppelin] olkkoti opened a new pull request #4055: [ZEPPELIN-5078]
olkkoti opened a new pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055
### What is this PR for?
Make it possible to cancel "run all paragraphs" operation. Currently, Cancel is blocked by UI as well as blocking "run all" operation on server. This PR will unblock cancel from UI and do "run all" operation in separate thread and so avoid blocking the websocket.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5078
### How should this be tested?
Two automatic tests in zeppelin-integration package.
I have problems with CI, but I am able to run them successfully locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#discussion_r576741689
##########
File path: flink-cmd/pom.xml
##########
@@ -23,14 +23,14 @@
<parent>
<artifactId>zeppelin-interpreter-parent</artifactId>
<groupId>org.apache.zeppelin</groupId>
- <version>0.10.0-SNAPSHOT</version>
+ <version>0.9.1-SNAPSHOT</version>
Review comment:
Yes, usually we create PR based on master branch and will cherry-pick that into branch-0.9 when merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#issuecomment-781187595
@olkkoti I think this is unrelated, because I see this error in master as well. But it would better to run CI again, because this is flaky test, sometimes fails and sometimes succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] olkkoti commented on a change in pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
olkkoti commented on a change in pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#discussion_r576706701
##########
File path: flink-cmd/pom.xml
##########
@@ -23,14 +23,14 @@
<parent>
<artifactId>zeppelin-interpreter-parent</artifactId>
<groupId>org.apache.zeppelin</groupId>
- <version>0.10.0-SNAPSHOT</version>
+ <version>0.9.1-SNAPSHOT</version>
Review comment:
Yes, I am building on branch-0.9. Should I target this bug fix to master instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#issuecomment-782554621
Thanks @olkkoti CI is passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] olkkoti commented on a change in pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
olkkoti commented on a change in pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#discussion_r576815785
##########
File path: flink-cmd/pom.xml
##########
@@ -23,14 +23,14 @@
<parent>
<artifactId>zeppelin-interpreter-parent</artifactId>
<groupId>org.apache.zeppelin</groupId>
- <version>0.10.0-SNAPSHOT</version>
+ <version>0.9.1-SNAPSHOT</version>
Review comment:
Ok, I changed to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] olkkoti commented on a change in pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
olkkoti commented on a change in pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#discussion_r576690683
##########
File path: flink-cmd/pom.xml
##########
@@ -23,14 +23,14 @@
<parent>
<artifactId>zeppelin-interpreter-parent</artifactId>
<groupId>org.apache.zeppelin</groupId>
- <version>0.10.0-SNAPSHOT</version>
+ <version>0.9.1-SNAPSHOT</version>
Review comment:
Ah, should parents refer to version 0.10.0 in both flink-cmd and spark-submit? At least I am not able to build that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#discussion_r576666774
##########
File path: flink-cmd/pom.xml
##########
@@ -23,14 +23,14 @@
<parent>
<artifactId>zeppelin-interpreter-parent</artifactId>
<groupId>org.apache.zeppelin</groupId>
- <version>0.10.0-SNAPSHOT</version>
+ <version>0.9.1-SNAPSHOT</version>
Review comment:
This change is not necessary. We use 0.9.1-SNAPSHOT for branch-0.9, and 0.10.0-SNAPSHOT for master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#issuecomment-780595547
@olkkoti There're still some failed selenium tests. Although there're some flaky test in selenium tests, but not sure whether it is related with your PR. Could you help to take a look at that ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] olkkoti commented on pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
olkkoti commented on pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#issuecomment-781044413
> @olkkoti There're still some failed selenium tests. Although there're some flaky test in selenium tests, but not sure whether it is related with your PR. Could you help to take a look at that ?
I fixed my cancel tests to have shorter sleep times in paragraphs, and made so that they actually complete even if the tests fail.
The latest run seems to be a lot better, however there is still one error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#issuecomment-782693368
Will merge if no more comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055#discussion_r576704166
##########
File path: flink-cmd/pom.xml
##########
@@ -23,14 +23,14 @@
<parent>
<artifactId>zeppelin-interpreter-parent</artifactId>
<groupId>org.apache.zeppelin</groupId>
- <version>0.10.0-SNAPSHOT</version>
+ <version>0.9.1-SNAPSHOT</version>
Review comment:
No, all the versions should be 0.9.1-SNAPSHOT, do you mean you unable to build branch-0.9 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4055:
URL: https://github.com/apache/zeppelin/pull/4055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org