You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/04/16 11:26:28 UTC
[GitHub] flink pull request #5853: [FLINK-9145] [table] Clean up flink-table dependen...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5853
[FLINK-9145] [table] Clean up flink-table dependencies
## What is the purpose of the change
This PR cleans up the flink-table dependencies. It should also fix the website build that is currently failing due to the Maven enforcer plugin for multiple dependency versions.
## Brief change log
- Updated pom.xml with excluded Janino and Apache Commons
## Verifying this change
Run end-to-end streaming SQL test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-9145
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5853
----
commit f06eb841e63f505c4d8313657f3aa813f4d36637
Author: Timo Walther <tw...@...>
Date: 2018-04-16T11:02:22Z
[FLINK-9145] [table] Clean up flink-table dependencies
----
---
[GitHub] flink issue #5853: [FLINK-9145] [table] Clean up flink-table dependencies
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5853
Thank you @zentol. Will implement you comment and merge this...
---
[GitHub] flink pull request #5853: [FLINK-9145] [table] Clean up flink-table dependen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5853
---
[GitHub] flink issue #5853: [FLINK-9145] [table] Clean up flink-table dependencies
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5853
Thanks for the feedback @zentol. Can you take another look?
---
[GitHub] flink pull request #5853: [FLINK-9145] [table] Clean up flink-table dependen...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5853#discussion_r181706338
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -102,9 +114,24 @@ under the License.
<groupId>commons-dbcp</groupId>
<artifactId>commons-dbcp</artifactId>
</exclusion>
+ <!-- Use Flink specific commons-lang version instead -->
+ <exclusion>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ </exclusion>
+ <!-- Use Flink specific Janino version instead -->
+ <exclusion>
--- End diff --
instead of exclusions you can also add an entry to the `dependencyManagement`
---
[GitHub] flink pull request #5853: [FLINK-9145] [table] Clean up flink-table dependen...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5853#discussion_r181722455
--- Diff: flink-formats/flink-json/pom.xml ---
@@ -112,4 +112,25 @@ under the License.
</build>
</profile>
</profiles>
+
+ <build>
+ <plugins>
+ <!-- Enable enforcer plugin for checking dependency convergence -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dependency-convergence</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <skip>false</skip>
--- End diff --
shouldn't be necessary for flink-json. we need it in flink-table since we disable the enforcer in flink-libraries.
---
[GitHub] flink issue #5853: [FLINK-9145] [table] Clean up flink-table dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5853
dependency convergence still fails:
```
Dependency convergence error for com.google.guava:guava:19.0 paths to dependency are:
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-org.apache.calcite:calcite-core:1.16.0
+-org.apache.calcite:calcite-linq4j:1.16.0
+-com.google.guava:guava:19.0
and
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-org.apache.calcite:calcite-core:1.16.0
+-com.google.guava:guava:19.0
and
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-org.apache.flink:flink-test-utils_2.11:1.6-SNAPSHOT
+-org.apache.curator:curator-test:2.12.0
+-com.google.guava:guava:16.0.1
[WARNING]
Dependency convergence error for commons-beanutils:commons-beanutils:1.8.0 paths to dependency are:
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-commons-configuration:commons-configuration:1.7
+-commons-digester:commons-digester:1.8.1
+-commons-beanutils:commons-beanutils:1.8.0
and
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-commons-configuration:commons-configuration:1.7
+-commons-beanutils:commons-beanutils:1.8.3
[WARNING]
Dependency convergence error for commons-lang:commons-lang:2.6 paths to dependency are:
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-commons-configuration:commons-configuration:1.7
+-commons-lang:commons-lang:2.6
and
+-org.apache.flink:flink-table_2.11:1.6-SNAPSHOT
+-org.apache.calcite:calcite-core:1.16.0
+-net.hydromatic:aggdesigner-algorithm:6.0
+-commons-lang:commons-lang:2.4
```
---
[GitHub] flink issue #5853: [FLINK-9145] [table] Clean up flink-table dependencies
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5853
I suggest to actually enable the dependency convergence for flink-table as we've already done the required work.
---