You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/06/16 13:56:20 UTC

[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/336
  
    I didn't re-test this but both travis builds are good and the code looks right. Just a side note - @pluradj I didn't review this but note that we have a bit of an ugly reality where `TestHelper` has a twin over in `gremlin-core/test`. There are test classes in there that need that kind of functionality and since `gremlin-core` can't depend on `gremlin-test` I just copied the file. :grimacing: Note sure if any of your changes needs to be propagated over there or not, but probably something you should look at before you finalize this one and merge. Pending that little investigation:
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---