You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/04/24 16:51:33 UTC
[Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
#509: Test compatibility with XMLRPC Plug-in
---------------------+---------------
Reporter: mbooth | Owner:
Type: task | Status: new
Priority: major | Version:
Resolution: |
---------------------+---------------
As discussed on the mailing list, please check the compatibility of the
Trac XML-RPC plugin.
http://mail-archives.apache.org/mod_mbox/bloodhound-
dev/201304.mbox/%3C5177E2CC.9020804@wandisco.com%3E
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: mbooth
Type: task | Status: review
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
Replying to [comment:11 olemis]:
>
> Hi Matt !
>
> Replying to [comment:7 mbooth]:
>
[...]
> All plugin tests are successful in my local working copy after applying
the following patches (order matters).
>
> {{{#!sh
>
> $ hg qapplied
> t509/t509_r1477773_tracadmin_globalcmd_attr.diff
> t514/t514_r1477773_load_bootstrap_handler.diff
> t514/t514_r1477773_tracd_bootstrap.diff
>
> $ hg log -r qparent --template="[{svnrev}] - {desc}\n"
> [1480224] - Translate SELECT part of CREATE TABLE ... AS SELECT ...
queries.
>
> Fixes an issue where some product plugin tables were prepopulated with
> rows from global product.
>
> }}}
>
JFYI , while working with patches [https://bitbucket.org/olemis
/bloodhound-mq/src/24ccf8543a114c57552ed376bd4662da06ff8389/?at=t509_bhrpc
this patch queue] might be helpful .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
ticket:514 is related to this .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
... compatibility side I mean ...
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: mbooth
Type: task | Status: review
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
I've added [attachment:t509_r1480735_mp_class_test_setup.diff a patch]
transforming some multi-product test case methods into class methods in
order to use them in `setUpClass` and `tearDownClass` methods supported by
recent versions of `unittest` module. [comment:11 Details] updated
accordingly .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: rjollos
Type: task | Status: review
Priority: critical | Milestone: Release 6
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by rjollos):
(In [1499182])
Change methods from instance to class methods to support multiproduct test
setup. Refs #509.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: closed
Priority: critical | Milestone: Release 6
Component: plugins | Version:
Resolution: fixed | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Changes (by olemis):
* status: review => closed
* resolution: => fixed
Comment:
Considering the test report for XML-RPC plugin test suite everything is ok
now. Should any other issue be noticed let's fix it on a separate ticket .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:19>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
------------------------+--------------------
Reporter: mbooth | Owner: nobody
Type: task | Status: new
Priority: major | Milestone:
Component: dashboard | Version:
Resolution: | Keywords:
------------------------+--------------------
Changes (by mbooth):
* owner: => nobody
* component: => dashboard
Old description:
> As discussed on the mailing list, please check the compatibility of the
> Trac XML-RPC plugin.
>
> http://mail-archives.apache.org/mod_mbox/bloodhound-
> dev/201304.mbox/%3C5177E2CC.9020804@wandisco.com%3E
New description:
As discussed on the mailing list, please check the compatibility of the
Trac XML-RPC plugin.
http://mail-archives.apache.org/mod_mbox/bloodhound-
dev/201304.mbox/%3C5177E2CC.9020804@wandisco.com%3E
If it doesn't work, please make it work (so you don't alienate
people/applications who already have working integrations with Trac
through this interface)
If it does work, I'd like to see it deployed to the test instances so I
test it out :-)
Thanks!
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
After applying [attachment:t509_r1471368_bhmp_nodeps_bhsearch.diff
attached patch] it is possible to run RPC test suite , still with failures
Details
{{{
#!sh
$ hg qapplied
t509/t509_r1471368_bhmp_nodeps_bhsearch.diff
$ hg log -r qparent --template="[{svnrev}] - {desc}\n"
[1471368] - More robust upgrade of attachments.
Can handle orphan attachments. When system wikis are duplicated
to the product env, attachment are copied as well. New tests.
$ python setup.py test -m tracrpc.tests
[...]
---------------------------
Ran 50 tests in 84.844s
FAILED (failures=4, errors=5)
Stopping web server...
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by mbooth):
Cool, thanks for your work on this.
I'm actually okay with a fork as long as the XML-RPC API remains
unchanged. There is already a lot of software out there that talks to Trac
programatically and it would be great if it all could also talk to
Bloodhound without change -- it would greatly lower the barrier to
adoption :-)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: rjollos
Type: task | Status: review
Priority: critical | Milestone: Release 6
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by rjollos):
(In [1495233])
Refs #509: Expose global commands in `ProductAdminModule`. Patch by
Olemis.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:16>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
Replying to [comment:5 mbooth]:
[...]
>
> If you need to patch the plug-in do you think it is feasible to make one
branch of code work in both Trac and Bloodhound/MultiProduct?
[...]
All I can say now , beyond previous comments , is that a solution for #504
has to implemented in order to make this happen .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: mbooth
Type: task | Status: review
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Changes (by olemis):
* status: accepted => review
* owner: olemis => mbooth
Comment:
Hi Matt !
Replying to [comment:7 mbooth]:
> Cool, thanks for your work on this.
>
> I'm actually okay with a fork as long as the XML-RPC API remains
unchanged. There is already a lot of software out there that talks to Trac
programatically and it would be great if it all could also talk to
Bloodhound without change -- it would greatly lower the barrier to
adoption :-)
I have pushed some changes onto [https://bitbucket.org/olemis/bloodhound-
rpc/src/8075ed8a7cd4?at=bloodhound_rpc bloodhound_rpc branch] in
[https://bitbucket.org/olemis/bloodhound-rpc olemis/bloodhound-rpc
repository @ Bitbucket] . All plugin tests are successful in my local
working copy after applying the following patches (order matters).
{{{#!sh
$ hg qapplied
t509/t509_r1477773_tracadmin_globalcmd_attr.diff
t514/t514_r1477773_load_bootstrap_handler.diff
t514/t514_r1477773_tracd_bootstrap.diff
$ hg log -r qparent --template="[{svnrev}] - {desc}\n"
[1480224] - Translate SELECT part of CREATE TABLE ... AS SELECT ...
queries.
Fixes an issue where some product plugin tables were prepopulated with
rows from global product.
}}}
After reviewing [https://bitbucket.org/olemis/bloodhound-
rpc/compare/bloodhound_rpc..#diff the differences] it is possible to
realize that not much has changed in the plugin but there are subtle
(backwards compatible) usage differences if running against product
environments .
Please review .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: review
Priority: critical | Milestone: Release 6
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Changes (by rjollos):
* owner: rjollos => olemis
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:18>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
Replying to [comment:5 mbooth]:
> So does this need fixing in Bloodhound or the plug-in?
>
Accurate answers will be available once a resolution is found . At least
for moment the I'm working on a fork of XmlRpcPlugin (namely BloodhoundRPC
plugin) . Depending on the nature of the changes needed , different things
might happen .
> If you need to patch the plug-in do you think it is feasible to make one
branch of code work in both Trac and Bloodhound/MultiProduct? (The
upstream maintainer may be more willing to take the patch...)
>
I'm co-maintainer of XmlRpcPlugin but I do not have commit access to
plugin's svn area @ t.h.o , only the maintainer . AFAICT , I'm not sure it
will be easy to push Bloodhound-specific patches to distribute them with
mainstream XmlRpcPlugin , at least until they prove to play nice with Trac
as well . But the fact is that e.g. the testing environment is completely
different , it's an extra maintenance overhead , etc ...
> Or will it be necessary to fork?
... so I just [https://bitbucket.org/olemis/bloodhound-rpc forked
XmlRpcPlugin @ Bitbucket] ;)
PS: We can try other alternatives later .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: rjollos
Type: task | Status: review
Priority: critical | Milestone: Release 6
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Changes (by rjollos):
* owner: mbooth => rjollos
* milestone: => Release 6
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Changes (by olemis):
* status: new => accepted
* keywords: => rpc XmlRpcPlugin
* component: dashboard => plugins
* owner: nobody => olemis
* priority: major => critical
Comment:
I'm taking a look into this . Will reply with further details asap .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: mbooth
Type: task | Status: review
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
Patches refreshed see comment:4:ticket:387
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by olemis):
Partial status report :
After applying the patches proposed in comment:4:ticket:514 it is possible
to submit authenticated requests to product environments via RPC .
Nevertheless :
{{{
#!sh
$ /srv/venv/python/trac/0.13/bin/python setup.py test -m
tracrpc.tests.ticket
[...]
-------------------
Ran 19 tests in 23.457s
FAILED (failures=4)
Stopping web server...
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #509: Test compatibility with XMLRPC Plug-in
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#509: Test compatibility with XMLRPC Plug-in
-----------------------+------------------------------
Reporter: mbooth | Owner: olemis
Type: task | Status: accepted
Priority: critical | Milestone:
Component: plugins | Version:
Resolution: | Keywords: rpc XmlRpcPlugin
-----------------------+------------------------------
Comment (by mbooth):
So does this need fixing in Bloodhound or the plug-in?
If you need to patch the plug-in do you think it is feasible to make one
branch of code work in both Trac and Bloodhound/MultiProduct? (The
upstream maintainer may be more willing to take the patch...)
Or will it be necessary to fork?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/509#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker