You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/12/06 04:40:53 UTC
[kudu-CR] [util] a few test scenarios for KLOG EVERY N SECS() macro
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20757
Change subject: [util] a few test scenarios for KLOG_EVERY_N_SECS() macro
......................................................................
[util] a few test scenarios for KLOG_EVERY_N_SECS() macro
This patch adds a couple of extra test scenarios on the behavior
of the KLOG_EVERY_N_SECS() macro.
Change-Id: I1b77ba3e9ef43ba71f72efe4051324bbf1b836b4
---
M src/kudu/util/logging-test.cc
1 file changed, 61 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/20757/1
--
To view, visit http://gerrit.cloudera.org:8080/20757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b77ba3e9ef43ba71f72efe4051324bbf1b836b4
Gerrit-Change-Number: 20757
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] a few test scenarios for KLOG EVERY N SECS() macro
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20757 )
Change subject: [util] a few test scenarios for KLOG_EVERY_N_SECS() macro
......................................................................
[util] a few test scenarios for KLOG_EVERY_N_SECS() macro
This patch adds a couple of extra test scenarios on the behavior
of the KLOG_EVERY_N_SECS() macro.
Change-Id: I1b77ba3e9ef43ba71f72efe4051324bbf1b836b4
Reviewed-on: http://gerrit.cloudera.org:8080/20757
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/logging-test.cc
1 file changed, 61 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b77ba3e9ef43ba71f72efe4051324bbf1b836b4
Gerrit-Change-Number: 20757
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [util] a few test scenarios for KLOG EVERY N SECS() macro
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20757 )
Change subject: [util] a few test scenarios for KLOG_EVERY_N_SECS() macro
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b77ba3e9ef43ba71f72efe4051324bbf1b836b4
Gerrit-Change-Number: 20757
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Dec 2023 17:38:49 +0000
Gerrit-HasComments: No