You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/08 14:41:20 UTC
[GitHub] [doris] luozenglin opened a new pull request, #14949: [pipeline](mysqlscan) support mysql scan node
luozenglin opened a new pull request, #14949:
URL: https://github.com/apache/doris/pull/14949
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14949:
URL: https://github.com/apache/doris/pull/14949#issuecomment-1342844448
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #14949:
URL: https://github.com/apache/doris/pull/14949#discussion_r1043972658
##########
be/src/pipeline/exec/mysql_scan_operator.h:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <utility>
+
+#include "operator.h"
+
+namespace doris::vectorized {
+class VMysqlScanNode;
+} // namespace doris::vectorized
+
+namespace doris::pipeline {
+
+class MysqlScanOperatorBuilder : public OperatorBuilder<vectorized::VMysqlScanNode> {
+public:
+ MysqlScanOperatorBuilder(int32_t id, ExecNode* exec_node);
+ bool is_source() const override { return true; }
+ OperatorPtr build_operator() override;
+};
+
+class MysqlScanOperator : public Operator<MysqlScanOperatorBuilder> {
Review Comment:
Please rebase master and replace Operator by SourceOperator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14949:
URL: https://github.com/apache/doris/pull/14949#issuecomment-1343761672
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14949:
URL: https://github.com/apache/doris/pull/14949#issuecomment-1342849058
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #14949:
URL: https://github.com/apache/doris/pull/14949#discussion_r1043972658
##########
be/src/pipeline/exec/mysql_scan_operator.h:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <utility>
+
+#include "operator.h"
+
+namespace doris::vectorized {
+class VMysqlScanNode;
+} // namespace doris::vectorized
+
+namespace doris::pipeline {
+
+class MysqlScanOperatorBuilder : public OperatorBuilder<vectorized::VMysqlScanNode> {
+public:
+ MysqlScanOperatorBuilder(int32_t id, ExecNode* exec_node);
+ bool is_source() const override { return true; }
+ OperatorPtr build_operator() override;
+};
+
+class MysqlScanOperator : public Operator<MysqlScanOperatorBuilder> {
Review Comment:
Please rebase master and replace Operator by SourceOperator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14949:
URL: https://github.com/apache/doris/pull/14949#issuecomment-1342940670
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.75 seconds
load time: 453 seconds
storage size: 17123356217 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221208155629_clickbench_pr_60512.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #14949: [pipeline](mysqlscan) support mysql scan node
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #14949:
URL: https://github.com/apache/doris/pull/14949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org