You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/24 23:23:51 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #14436: BugFix: Serialize max_retry_delay as a timedelta

kaxil commented on a change in pull request #14436:
URL: https://github.com/apache/airflow/pull/14436#discussion_r582377687



##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -856,7 +860,7 @@ def test_no_new_fields_added_to_base_operator(self):
             'executor_config': {},
             'inlets': [],
             'label': '10',
-            'max_retry_delay': None,
+            'max_retry_delay': timedelta(0, 600),

Review comment:
       This should still be None as we haven't change the default value

##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -856,7 +860,7 @@ def test_no_new_fields_added_to_base_operator(self):
             'executor_config': {},
             'inlets': [],
             'label': '10',
-            'max_retry_delay': None,
+            'max_retry_delay': timedelta(0, 600),

Review comment:
       This should still be None as we haven't changed the default value




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org