You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Murtuza Shareef (Jira)" <ji...@apache.org> on 2020/04/24 14:55:00 UTC
[jira] [Created] (MINIFICPP-1207) Refactor core ProcessSession::get
and ProcessSession::commit functions for unnecessary and duplicated code
Murtuza Shareef created MINIFICPP-1207:
------------------------------------------
Summary: Refactor core ProcessSession::get and ProcessSession::commit functions for unnecessary and duplicated code
Key: MINIFICPP-1207
URL: https://issues.apache.org/jira/browse/MINIFICPP-1207
Project: Apache NiFi MiNiFi C++
Issue Type: Improvement
Reporter: Murtuza Shareef
[https://github.com/apache/nifi-minifi-cpp/blob/master/libminifi/src/core/ProcessSession.cpp]
On line 944 it doesn't make sense to create a new FlowFile and then loose reference to it on line 952. I think the original intent of this code was to store a shared reference to the flowfile object in _originalFlowFiles table.
Also, there is code duplication in ProcessSession::commit function.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)