[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4150: [BUG] fix 4149, add sessionVariable to choose broadcastjoin first when cardinality cannot be estimated

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #4150:
URL: https://github.com/apache/incubator-doris/pull/4150#discussion_r459293826



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -286,7 +286,8 @@ private PlanFragment createScanFragment(PlanNode node) {
      * Therefore, we add a SessionVariable to help users choose a better join implementation.
      */
     private boolean isBroadcastCostSmaller(long broadcastCost, long partitionCost)  {
-        if (ConnectContext.get().getSessionVariable().isPreferBroadcastJoin()) {
+        String joinMethod = ConnectContext.get().getSessionVariable().getPreferJoinMethod();
+        if (joinMethod.equals("broadcast")) {

Review comment:
       `equalsIgnoreCase` should more better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org