You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/11 21:50:55 UTC

Review Request 47264: GEODE-1252: modify bits atomically

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47264/
-----------------------------------------------------------

Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-1252
    https://issues.apache.org/jira/browse/GEODE-1252


Repository: geode


Description
-------

The bits field is now modified atomically using a AtomicIntegerFieldUpdater.
Also added unit test for bit methods


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/VersionTag.java 60e4299d5dfd13803b2e7f8e9b1aab858e8d1982 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/AbstractVersionTagTestBase.java PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/VMVersionTagTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/47264/diff/


Testing
-------

precheckin


Thanks,

Darrel Schneider


Re: Review Request 47264: GEODE-1252: modify bits atomically

Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47264/#review132767
-----------------------------------------------------------


Ship it!




Ship It!

- Ken Howe


On May 11, 2016, 9:50 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47264/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 9:50 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1252
>     https://issues.apache.org/jira/browse/GEODE-1252
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The bits field is now modified atomically using a AtomicIntegerFieldUpdater.
> Also added unit test for bit methods
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/VersionTag.java 60e4299d5dfd13803b2e7f8e9b1aab858e8d1982 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/AbstractVersionTagTestBase.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/VMVersionTagTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47264/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>


Re: Review Request 47264: GEODE-1252: modify bits atomically

Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47264/#review132769
-----------------------------------------------------------


Ship it!




Ship It!

- Scott Jewell


On May 11, 2016, 9:50 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47264/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 9:50 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1252
>     https://issues.apache.org/jira/browse/GEODE-1252
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The bits field is now modified atomically using a AtomicIntegerFieldUpdater.
> Also added unit test for bit methods
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/VersionTag.java 60e4299d5dfd13803b2e7f8e9b1aab858e8d1982 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/AbstractVersionTagTestBase.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/VMVersionTagTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47264/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>