You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/03 12:03:00 UTC

[jira] [Work logged] (ARTEMIS-3409) DNSSwitchTest skips on Java 8 but fails on Java 11+ if preconditions not satisfied

     [ https://issues.apache.org/jira/browse/ARTEMIS-3409?focusedWorklogId=632863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632863 ]

ASF GitHub Bot logged work on ARTEMIS-3409:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Aug/21 12:02
            Start Date: 03/Aug/21 12:02
    Worklog Time Spent: 10m 
      Work Description: gemmellr opened a new pull request #3681:
URL: https://github.com/apache/activemq-artemis/pull/3681


   Make DNSSwitchTest consistent on Java8 and 11+. Splits the OS check out to allow running separately, updates test to do that first, avoiding followup notes/checks about sudo and etc-hosts where it doesnt make sense. Changes the 'failIfNotSudo' to 'skipIfNotSudo' and runs this earlier for the Java 11+ cases, making DNSSwitchTest consistently skip if needed and print out details on why.
   
   Change also stops NetworkFailureFailoverTest failing for similar reasons, instead making it skip and print details. Updated its intro text accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 632863)
    Remaining Estimate: 0h
            Time Spent: 10m

> DNSSwitchTest skips on Java 8 but fails on Java 11+ if preconditions not satisfied
> ----------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3409
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3409
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 2.17.0
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Major
>             Fix For: 2.18.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The DNSSwitchTest smoke test does slightly different things to operate on Java 8 and Java 11+, and as a result makes different precondition checks for the two cases. These can behave quite differently, such that when it cant run on Java 8 it typically skips, but when it cant run on Java 11 it typically outright fails.
> It should be consistent and skip when any preconditions for running cant be satisfied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)