You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Thomas Graves (JIRA)" <ji...@apache.org> on 2013/03/28 20:19:19 UTC
[jira] [Commented] (MAPREDUCE-5007) fix coverage
org.apache.hadoop.mapreduce.v2.hs
[ https://issues.apache.org/jira/browse/MAPREDUCE-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616559#comment-13616559 ]
Thomas Graves commented on MAPREDUCE-5007:
------------------------------------------
Can you add timeouts to all the tests. Also can you change the single line comments to just have // in front of them and wrap at 80 characters. if multiple line use format:
/*
*
*/
In the test testReports. it calls jobHistory.getAllJobs() but doesn't validate anything. I'm also not real fond of it relying on the JobHistory being the first service in the JobHistoryServer (historyServer.getServices().iterator().next()).
In TestJobHistoryServer it would be better to make sure the history server is stopped in an @After function. The testPartialJob might be better placed in another file, perhaps TestJobHistoryEntities.
> fix coverage org.apache.hadoop.mapreduce.v2.hs
> ----------------------------------------------
>
> Key: MAPREDUCE-5007
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5007
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7
> Reporter: Aleksey Gorshkov
> Assignee: Aleksey Gorshkov
> Attachments: MAPREDUCE-5007-branch-0.23.patch, MAPREDUCE-5007-branch-2.patch, MAPREDUCE-5007-trunk.patch
>
>
> fix coverage org.apache.hadoop.mapreduce.v2.hs
> MAPREDUCE-5007-trunk.patch patch for trunk
> MAPREDUCE-5007-branch-2.patch patch for branch-2
> MAPREDUCE-5007-branch-0.23.patch patch for branch-0.23
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira