[jira] [Commented] (THRIFT-1217) Use evutil_socketpair instead of pipe (Windows port)

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059140#comment-13059140 ] 

Roger Meier commented on THRIFT-1217:
-------------------------------------

Yes, you are right. This is a libevent topic and not Windows Port relevant.

I use libevent 1.4.13-stable-1 on Debian Squeeze and this version does not provide evutil_socket_t

fixed that with the following define within lib/cpp/src/server/TNonblockingServer.h
#define evutil_socket_t int 

one of the following defines should control the evutil_socket_t support, which one, which version?
#define LIBEVENT_VERSION
#define LIBEVENT_VERSION_NUMBER

Could you provide a updated patch without windows headers and with an updated evutil_socket_t check rule?

> Use evutil_socketpair instead of pipe (Windows port)
> ----------------------------------------------------
>
>                 Key: THRIFT-1217
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1217
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.6.1, 0.7
>         Environment: Windows C++ 9.0, 10.0
>            Reporter: alexandre parenteau
>            Priority: Minor
>              Labels: patch
>             Fix For: 0.7
>
>         Attachments: evutil_socketpair.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> As part of an effort to use the Non-Blocking server (using libevent) on Windows, it was necessary to remove the use of "pipe" for the notification mechanism to signal end-of-task. We propose to use evutil_socketpair instead (tested with libevent 2.0.12). Patch included. Please see https://github.com/aubonbeurre/thrift/blob/alex-0.6.1/README.non.blocking.Windows for more details.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira