You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2016/05/04 15:47:19 UTC
svn commit: r1742298 -
/maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
Author: khmarbaise
Date: Wed May 4 15:47:19 2016
New Revision: 1742298
URL: http://svn.apache.org/viewvc?rev=1742298&view=rev
Log:
Slight enhancements
o Added error checking.
o Improved error message.
o Improved comments.
Modified:
maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
Modified: maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java?rev=1742298&r1=1742297&r2=1742298&view=diff
==============================================================================
--- maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java (original)
+++ maven/plugins/trunk/maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java Wed May 4 15:47:19 2016
@@ -628,7 +628,10 @@ public abstract class AbstractInvokerMoj
+ reportsDirectory.getAbsolutePath(), e );
}
}
- reportsDirectory.mkdirs();
+ if ( !reportsDirectory.mkdirs() )
+ {
+ throw new MojoExecutionException( "Failure while creating the " + reportsDirectory.getAbsolutePath() );
+ }
}
BuildJob[] buildJobs;
@@ -695,13 +698,13 @@ public abstract class AbstractInvokerMoj
}
catch ( IOException e )
{
- getLog().error( "Failure...", e );
+ getLog().error( "Failure during scanning of folders.", e );
}
if ( setupBuildJobs != null )
{
- // parallelThreads = 1 for this call
- // run all setup jobs only single thread.
+ // Run setup jobs in single thread
+ // mode.
//
// Some Idea about ordering?
getLog().info( "Running Setup Jobs" );
@@ -710,7 +713,8 @@ public abstract class AbstractInvokerMoj
// Afterwards run all other jobs.
BuildJob[] nonSetupBuildJobs = getNonSetupJobs( buildJobs );
- // parallelThreads run the rest with parallel sets...
+ // We will run the non setup jobs with the configured
+ // parallelThreads number.
runBuilds( projectsDir, nonSetupBuildJobs, parallelThreads );
writeSummaryFile( nonSetupBuildJobs );
@@ -1240,7 +1244,6 @@ public abstract class AbstractInvokerMoj
try
{
- // TODO: Think about running SETUP jobs only single thread.
if ( runWithParallelThreads > 1 )
{
getLog().info( "use parallelThreads " + runWithParallelThreads );