You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/12 15:12:30 UTC

[GitHub] [beam] rionmonster commented on pull request #13975: [BEAM-11806] Explicit Partition Support for KafkaIO.WriteRecords

rionmonster commented on pull request #13975:
URL: https://github.com/apache/beam/pull/13975#issuecomment-778252803


   Thanks Alexey,
   
   I've updated the original commit message to include the JIRA issue as recommended. Do you know of the more appropriate place within the repository to add the unit test? I see quite a bit of Kafka-related tests across the place, but wasn't sure where something like this would best fit.
   
   Additionally, I do feel that the recommended refactoring would be most appropriate in this case (i.e. sending the `ProducerRecord` instance itself instead of creating a new instance). IMO, that change makes more sense, but I'll leave it up to you if that's the referred fix here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org