You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/06/30 16:02:56 UTC
[PR] dep: pin transitive dep `google-cloud-storage >=2.0.0` [iceberg-python]
kevinjqliu opened a new pull request, #2161:
URL: https://github.com/apache/iceberg-python/pull/2161
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Older versions of google libraries throw
```
E UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
```
We found a temporary workaround by manually upgrading the libraries in #2127
However, other libraries might depend on these packages and will revert them back to the <2.0 versions. For example, #2145
This PR pins the top-level `google-cloud-storage` to `>=2.0.0` to mitigate this issue.
The side effect is #2145 wont be necessary anymore since cachetools@6.1.0 wont satisfy the dependency constraints
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dep: pin transitive dep `google-cloud-storage >=2.0.0` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed pull request #2161: dep: pin transitive dep `google-cloud-storage >=2.0.0`
URL: https://github.com/apache/iceberg-python/pull/2161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dep: pin transitive dep `google-cloud-storage >=2.0.0` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2161:
URL: https://github.com/apache/iceberg-python/pull/2161#issuecomment-3042424453
> But cachetools does not have any dependencies, so also not on google-cloud-storage. Why does it lower the GCP dependencies
I found the culprit! `poetry show --tree`:
```
├── google-cloud-storage *
│ ├── google-api-core >=2.15.0,<3.0.0
│ │ ├── google-auth >=2.14.1,<3.0.0
│ │ │ ├── cachetools >=2.0.0,<6.0
```
`google-auth` sets an upper limit for `cachetools`. Confirmed [here](https://github.com/googleapis/google-auth-library-python/blob/ca94ead4035beea4741dc5384449032f8e6f75d8/setup.py#L23)
So the resolver finds the version of `google-auth` without this constraint
```
├── google-cloud-storage *
│ ├── google-auth >=1.2.0
│ │ ├── cachetools >=2.0.0
```
> Adding this constraint would put an unnecessary constraint on the users. We fail on errors, to make sure that we fix deprecations in time, but I don't think this is the right fix.
Agreed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dep: pin transitive dep `google-cloud-storage >=2.0.0` [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2161:
URL: https://github.com/apache/iceberg-python/pull/2161#issuecomment-3019844000
I'm confused by both the dependabot PR, but also this one 🤣
PyIceberg directly depends on `cachetools`: https://github.com/apache/iceberg-python/blob/5e975d569e243f1e67e8021a6f941cd77b08d926/pyproject.toml#L82
But `cachetools` does not not have any dependencies, so also not on `google-cloud-storage`. Why does it lower the GCP dependencies: https://github.com/apache/iceberg-python/pull/2145/files#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89L1706-L1717 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org