You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/07/24 23:13:12 UTC

[GitHub] [struts] rproserpio opened a new pull request, #580: Reverting injection refactor of internal bean

rproserpio opened a new pull request, #580:
URL: https://github.com/apache/struts/pull/580

   In commit e9d0a5518cd0671d9ad0353a2c87246ef0d2061b ContentTypeHandlerManager has been changed from setter-injected to constructor-injected.
   However, at least with spring as the object factory, that bean was an internal bean not available from the factory, injected post construction.
   In the 6.0.0 implementation ContentTypeInterceptor cannot be instantiated since its dependency cannot be resolved:
   ```
   org.springframework.beans.factory.UnsatisfiedDependencyException
   
   Error creating bean with name 'org.apache.struts2.rest.ContentTypeInterceptor': Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.struts2.rest.ContentTypeHandlerManager' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {}
   ```
   This commit attempts to revert that change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] [struts] lukaszlenart merged pull request #580: [WW-5205] - Reverting injection refactor of internal bean

Posted by GitBox <gi...@apache.org>.
lukaszlenart merged PR #580:
URL: https://github.com/apache/struts/pull/580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] [struts] lukaszlenart commented on pull request #580: Reverting injection refactor of internal bean

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on PR #580:
URL: https://github.com/apache/struts/pull/580#issuecomment-1193568386

   Could you create a JIRA ticket here https://issues.apache.org/jira/projects/WW/issues?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [struts] lukaszlenart commented on pull request #580: [WW-5205] - Reverting injection refactor of internal bean

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on PR #580:
URL: https://github.com/apache/struts/pull/580#issuecomment-1208216190

   LGTM 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [struts] rproserpio commented on pull request #580: Reverting injection refactor of internal bean

Posted by GitBox <gi...@apache.org>.
rproserpio commented on PR #580:
URL: https://github.com/apache/struts/pull/580#issuecomment-1193661460

   > Could you create a JIRA ticket here https://issues.apache.org/jira/projects/WW/issues?
   
   Hi @lukaszlenart, I've created [WW-5205](https://issues.apache.org/jira/browse/WW-5205)
   Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org