You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/01/25 21:59:25 UTC
Review Request 55960: AMBARI-19715: HostCleanup remove ambari.repo
when ambari.repo has repo ID that doesn't begin with word AMBARI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55960/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-19715
https://issues.apache.org/jira/browse/AMBARI-19715
Repository: ambari
Description
-------
HostCleanup remove ambari.repo when ambari.repo has repo ID that doesn't begin with word AMBARI
Diffs
-----
ambari-agent/src/test/python/resource_management/TestPackagesAnalyzer.py f898919
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 9df2b64
Diff: https://reviews.apache.org/r/55960/diff/
Testing
-------
unit testing
run hostcheck custom action, verify the hostcheck_custom_action.result doesn't contain customely named Ambari repo, I used GITHUB_AMBARI as my ambari repo id.
Thanks,
Di Li
Re: Review Request 55960: AMBARI-19715: HostCleanup remove
ambari.repo when
ambari.repo has repo ID that doesn't begin with word AMBARI
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55960/#review163122
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On Jan. 25, 2017, 9:59 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55960/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 9:59 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-19715
> https://issues.apache.org/jira/browse/AMBARI-19715
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HostCleanup remove ambari.repo when ambari.repo has repo ID that doesn't begin with word AMBARI
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestPackagesAnalyzer.py f898919
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 9df2b64
>
> Diff: https://reviews.apache.org/r/55960/diff/
>
>
> Testing
> -------
>
> unit testing
> run hostcheck custom action, verify the hostcheck_custom_action.result doesn't contain customely named Ambari repo, I used GITHUB_AMBARI as my ambari repo id.
>
>
> Thanks,
>
> Di Li
>
>