You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/04 23:32:29 UTC
[GitHub] [kafka] hachikuji opened a new pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`
hachikuji opened a new pull request #8802:
URL: https://github.com/apache/kafka/pull/8802
The current "about" string incorrectly describes the session epoch as the partition epoch. Rename to `SessionEpoch` to make usage clearer. Also rename `MaxWait` to `MaxWaitTimeMs` and `FetchableTopic` to `FetchTopic` for consistency with `FetchPartition`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #8802:
URL: https://github.com/apache/kafka/pull/8802#discussion_r436389230
##########
File path: clients/src/main/resources/common/message/FetchRequest.json
##########
@@ -49,7 +49,7 @@
"fields": [
{ "name": "ReplicaId", "type": "int32", "versions": "0+",
"about": "The broker ID of the follower, of -1 if this request is from a consumer." },
- { "name": "MaxWait", "type": "int32", "versions": "0+",
+ { "name": "MaxWaitTimeMs", "type": "int32", "versions": "0+",
Review comment:
Fair enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #8802:
URL: https://github.com/apache/kafka/pull/8802#discussion_r436325309
##########
File path: clients/src/main/resources/common/message/FetchRequest.json
##########
@@ -49,7 +49,7 @@
"fields": [
{ "name": "ReplicaId", "type": "int32", "versions": "0+",
"about": "The broker ID of the follower, of -1 if this request is from a consumer." },
- { "name": "MaxWait", "type": "int32", "versions": "0+",
+ { "name": "MaxWaitTimeMs", "type": "int32", "versions": "0+",
Review comment:
Would `MaxWaitMs` be enough? The unit is typically enough to indicate it's time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #8802:
URL: https://github.com/apache/kafka/pull/8802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8802:
URL: https://github.com/apache/kafka/pull/8802#issuecomment-640721062
Request/response names are just labels for humans, so you can change them without affecting compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #8802:
URL: https://github.com/apache/kafka/pull/8802#discussion_r436325309
##########
File path: clients/src/main/resources/common/message/FetchRequest.json
##########
@@ -49,7 +49,7 @@
"fields": [
{ "name": "ReplicaId", "type": "int32", "versions": "0+",
"about": "The broker ID of the follower, of -1 if this request is from a consumer." },
- { "name": "MaxWait", "type": "int32", "versions": "0+",
+ { "name": "MaxWaitTimeMs", "type": "int32", "versions": "0+",
Review comment:
Would `MaxWaitMs` be enough? The unit is typically enough to indicate it's time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org