You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jo...@apache.org on 2007/02/26 22:19:19 UTC

svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Author: joehni
Date: Mon Feb 26 13:19:19 2007
New Revision: 512016

URL: http://svn.apache.org/viewvc?view=rev&rev=512016
Log:
Format new XML part.

Modified:
    maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Modified: maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml?view=diff&rev=512016&r1=512015&r2=512016
==============================================================================
--- maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml (original)
+++ maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml Mon Feb 26 13:19:19 2007
@@ -217,11 +217,11 @@
 			<artifactId>plexus-container-default</artifactId>
 			<version>1.0-alpha-9</version>
 		</dependency>
-        <dependency>
-          <groupId>org.apache.maven.shared</groupId>
-          <artifactId>maven-dependency-analyzer</artifactId>
-          <version>1.0-SNAPSHOT</version>
-        </dependency>
+		<dependency>
+		    <groupId>org.apache.maven.shared</groupId>
+		    <artifactId>maven-dependency-analyzer</artifactId>
+		    <version>1.0-SNAPSHOT</version>
+		</dependency>
 	</dependencies>
 	<!--reporting>
     <plugins>



Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by Trygve Laugstøl <tr...@apache.org>.
Jörg Schaible wrote:
> Dan Tran wrote:
> 
>> I think you broke the convention of 2 spaces indentation for xml file ;-)
> 
> Well, no. All the lines had tab indention except the new ones I added. So I
> converted them into tabs also ;-)

The convention is 2 spaces as indent so please fix the previous 
developer's work and keep it consistent :)

--
Trygve

> 
> - Jörg
> 
>> On 2/26/07, joehni@apache.org <jo...@apache.org> wrote:
>>> Author: joehni
>>> Date: Mon Feb 26 13:19:19 2007
>>> New Revision: 512016
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=512016
>>> Log:
>>> Format new XML part.
>>>
>>> Modified:
>>>    maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>>>
>>> Modified: maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>>> URL:
>>>
> http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml?view=diff&rev=512016&r1=512015&r2=512016
>>>
> ==============================================================================
>>> --- maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>>> (original) +++
>>> maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml Mon Feb 26
>>> 13:19:19 2007 @@ -217,11 +217,11 @@
>>>                        <artifactId>plexus-container-default</artifactId>
>>>                        <version>1.0-alpha-9</version>
>>>                </dependency>
>>> -        <dependency>
>>> -          <groupId>org.apache.maven.shared</groupId>
>>> -          <artifactId>maven-dependency-analyzer</artifactId>
>>> -          <version>1.0-SNAPSHOT</version>
>>> -        </dependency>
>>> +               <dependency>
>>> +                   <groupId>org.apache.maven.shared</groupId>
>>> +                   <artifactId>maven-dependency-analyzer</artifactId>
>>> +                   <version>1.0-SNAPSHOT</version>
>>> +               </dependency>
>>>        </dependencies>
>>>        <!--reporting>
>>>     <plugins>
>>>
>>>
>>>
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by Jörg Schaible <jo...@gmx.de>.
Brian E. Fox wrote:

> How close is the dependency analyzer shared piece from coming out of the
> sandbox and being released?

It's Mark's code, but from my PoV it simply works. So it should no problem
to release some kind of alpha version, indicating that Mark is going to add
more stuff.

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
My main concern is around merging into the dependency plugin that
creates a new dependency on a sandboxed item if it's really far away.
I'm thinking that it might make sense to keep the analyzer plugin
separate until this shared piece can be unsandboxed. If the current
version can be unsandboxed and prepared for release if we clearly note
in the dependency plugin docs that these goals are very alpha, then
that's ok. 

What does the PMC think?

-----Original Message-----
From: Mark Hobson [mailto:markhobson@gmail.com] 
Sent: Tuesday, February 27, 2007 11:09 AM
To: Maven Developers List
Subject: Re: Re: svn commit: r512016 -
/maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

On 27/02/07, Brian E. Fox <br...@reply.infinity.nu> wrote:
> How close is the dependency anayzer shared piece from coming out of
the sandbox and being released?

There's a couple of things I'd like to see before it was released:

- write some integration tests to fully verify the bytecode dependency
code
- abstract the concept of a dependency away from class files and make it
pluggable in order to support: classname references in XML files; Java
META-INF service files; etc.
- javadoc ;)

Still, it could be released in it's present form if there's demand to
warrant it.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by Mark Hobson <ma...@gmail.com>.
On 27/02/07, Brian E. Fox <br...@reply.infinity.nu> wrote:
> How close is the dependency analyzer shared piece from coming out of the sandbox and being released?

There's a couple of things I'd like to see before it was released:

- write some integration tests to fully verify the bytecode dependency code
- abstract the concept of a dependency away from class files and make
it pluggable in order to support: classname references in XML files;
Java META-INF service files; etc.
- javadoc ;)

Still, it could be released in it's present form if there's demand to
warrant it.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
How close is the dependency analyzer shared piece from coming out of the sandbox and being released?
 

-----Original Message-----
From: news [mailto:news@sea.gmane.org] On Behalf Of Jörg Schaible
Sent: Tuesday, February 27, 2007 10:26 AM
To: dev@maven.apache.org
Subject: Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Dan Tran wrote:

> I think you broke the convention of 2 spaces indentation for xml file 
> ;-)

Well, no. All the lines had tab indention except the new ones I added. So I converted them into tabs also ;-)

- Jörg

> 
> On 2/26/07, joehni@apache.org <jo...@apache.org> wrote:
>>
>> Author: joehni
>> Date: Mon Feb 26 13:19:19 2007
>> New Revision: 512016
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=512016
>> Log:
>> Format new XML part.
>>
>> Modified:
>>    maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>>
>> Modified: maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>> URL:
>>
http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml?view=diff&rev=512016&r1=512015&r2=512016
>>
>>
==============================================================================
>> --- maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>> (original) +++
>> maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml Mon Feb 
>> 26
>> 13:19:19 2007 @@ -217,11 +217,11 @@
>>                        <artifactId>plexus-container-default</artifactId>
>>                        <version>1.0-alpha-9</version>
>>                </dependency>
>> -        <dependency>
>> -          <groupId>org.apache.maven.shared</groupId>
>> -          <artifactId>maven-dependency-analyzer</artifactId>
>> -          <version>1.0-SNAPSHOT</version>
>> -        </dependency>
>> +               <dependency>
>> +                   <groupId>org.apache.maven.shared</groupId>
>> +                   <artifactId>maven-dependency-analyzer</artifactId>
>> +                   <version>1.0-SNAPSHOT</version>
>> +               </dependency>
>>        </dependencies>
>>        <!--reporting>
>>     <plugins>
>>
>>
>>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by Jörg Schaible <jo...@gmx.de>.
Dan Tran wrote:

> I think you broke the convention of 2 spaces indentation for xml file ;-)

Well, no. All the lines had tab indention except the new ones I added. So I
converted them into tabs also ;-)

- Jörg

> 
> On 2/26/07, joehni@apache.org <jo...@apache.org> wrote:
>>
>> Author: joehni
>> Date: Mon Feb 26 13:19:19 2007
>> New Revision: 512016
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=512016
>> Log:
>> Format new XML part.
>>
>> Modified:
>>    maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>>
>> Modified: maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>> URL:
>>
http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml?view=diff&rev=512016&r1=512015&r2=512016
>>
>>
==============================================================================
>> --- maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>> (original) +++
>> maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml Mon Feb 26
>> 13:19:19 2007 @@ -217,11 +217,11 @@
>>                        <artifactId>plexus-container-default</artifactId>
>>                        <version>1.0-alpha-9</version>
>>                </dependency>
>> -        <dependency>
>> -          <groupId>org.apache.maven.shared</groupId>
>> -          <artifactId>maven-dependency-analyzer</artifactId>
>> -          <version>1.0-SNAPSHOT</version>
>> -        </dependency>
>> +               <dependency>
>> +                   <groupId>org.apache.maven.shared</groupId>
>> +                   <artifactId>maven-dependency-analyzer</artifactId>
>> +                   <version>1.0-SNAPSHOT</version>
>> +               </dependency>
>>        </dependencies>
>>        <!--reporting>
>>     <plugins>
>>
>>
>>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r512016 - /maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml

Posted by Dan Tran <da...@gmail.com>.
I think you broke the convention of 2 spaces indentation for xml file ;-)

On 2/26/07, joehni@apache.org <jo...@apache.org> wrote:
>
> Author: joehni
> Date: Mon Feb 26 13:19:19 2007
> New Revision: 512016
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=512016
> Log:
> Format new XML part.
>
> Modified:
>    maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
>
> Modified: maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml
> URL:
> http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml?view=diff&rev=512016&r1=512015&r2=512016
>
> ==============================================================================
> --- maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml (original)
> +++ maven/sandbox/trunk/plugins/maven-dependency-plugin/pom.xml Mon Feb 26
> 13:19:19 2007
> @@ -217,11 +217,11 @@
>                        <artifactId>plexus-container-default</artifactId>
>                        <version>1.0-alpha-9</version>
>                </dependency>
> -        <dependency>
> -          <groupId>org.apache.maven.shared</groupId>
> -          <artifactId>maven-dependency-analyzer</artifactId>
> -          <version>1.0-SNAPSHOT</version>
> -        </dependency>
> +               <dependency>
> +                   <groupId>org.apache.maven.shared</groupId>
> +                   <artifactId>maven-dependency-analyzer</artifactId>
> +                   <version>1.0-SNAPSHOT</version>
> +               </dependency>
>        </dependencies>
>        <!--reporting>
>     <plugins>
>
>
>