You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2022/05/24 03:28:15 UTC

[incubator-doris] 02/04: [Bug-Fix][Vectorized] Full join return error result (#9690)

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git

commit e763465ec3be14fb89a84f5006c9e6d7b1ae6503
Author: HappenLee <ha...@hotmail.com>
AuthorDate: Mon May 23 13:29:37 2022 +0800

    [Bug-Fix][Vectorized] Full join return error result (#9690)
    
    Co-authored-by: lihaopeng <li...@baidu.com>
---
 be/src/vec/exec/join/vhash_join_node.cpp          | 2 +-
 regression-test/data/query/join/sql/full_join.out | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/be/src/vec/exec/join/vhash_join_node.cpp b/be/src/vec/exec/join/vhash_join_node.cpp
index 9335028438..7ec9f23439 100644
--- a/be/src/vec/exec/join/vhash_join_node.cpp
+++ b/be/src/vec/exec/join/vhash_join_node.cpp
@@ -1074,10 +1074,10 @@ Status HashJoinNode::extract_probe_join_column(Block& block, NullMap& null_map,
                 auto& col_nullmap = nullable->get_null_map_data();
 
                 ignore_null |= !_probe_not_ignore_null[i];
+                VectorizedUtils::update_null_map(null_map, col_nullmap);
                 if (_build_not_ignore_null[i]) {
                     raw_ptrs[i] = nullable;
                 } else {
-                    VectorizedUtils::update_null_map(null_map, col_nullmap);
                     raw_ptrs[i] = &col_nested;
                 }
             } else {
diff --git a/regression-test/data/query/join/sql/full_join.out b/regression-test/data/query/join/sql/full_join.out
new file mode 100644
index 0000000000..c219e27748
--- /dev/null
+++ b/regression-test/data/query/join/sql/full_join.out
@@ -0,0 +1,8 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !full_join --
+n fj n	\N	\N
+n fj n	\N	\N
+
+-- !full_join_2 --
+n fj n	\N	\N
+


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org