You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/12 14:50:23 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #36373: [SPARK-39041][SQL] Mapping Spark Query ResultSet/Schema to TRowSet/TTableSchema directly
cloud-fan commented on code in PR #36373:
URL: https://github.com/apache/spark/pull/36373#discussion_r871477878
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSession.java:
##########
@@ -182,11 +184,11 @@ OperationHandle getCrossReference(String primaryCatalog,
void closeOperation(OperationHandle opHandle) throws HiveSQLException;
- TableSchema getResultSetMetadata(OperationHandle opHandle)
+ TTableSchema getResultSetMetadata(OperationHandle opHandle)
throws HiveSQLException;
- RowSet fetchResults(OperationHandle opHandle, FetchOrientation orientation,
- long maxRows, FetchType fetchType) throws HiveSQLException;
+ TRowSet fetchResults(OperationHandle opHandle, FetchOrientation orientation,
+ long maxRows, FetchType fetchType) throws HiveSQLException;
Review Comment:
the previous indentation was correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org