You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/05 20:16:55 UTC
Review Request 18785: Replaced HELP strings with static methods to reduce
non-POD statics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18785/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1023
https://issues.apache.org/jira/browse/MESOS-1023
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/master/http.cpp a019f15615d028f3d3628b2611709fc8a3a81bf8
src/master/master.hpp 49a3e151d53b786027184c14b96371016a926497
src/master/master.cpp f7ba9aafe7d476b59f5333458ca9a63b0dc622b9
src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
src/slave/monitor.hpp c042bc1af31aedf7d2991741d3f8cb70ef353b40
src/slave/monitor.cpp 1c02986e22bc1dcbc2f07de546bf865d34c41c89
src/slave/slave.hpp 01b80dfc1dd55edd6d2f722ff1d4f1bf4d96f28e
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
Diff: https://reviews.apache.org/r/18785/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18785: Replaced HELP strings with static methods to
reduce non-POD statics
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18785/#review36510
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18784, 18785]
All tests passed.
- Mesos ReviewBot
On March 5, 2014, 7:16 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18785/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 7:16 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-1023
> https://issues.apache.org/jira/browse/MESOS-1023
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/master/http.cpp a019f15615d028f3d3628b2611709fc8a3a81bf8
> src/master/master.hpp 49a3e151d53b786027184c14b96371016a926497
> src/master/master.cpp f7ba9aafe7d476b59f5333458ca9a63b0dc622b9
> src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae
> src/slave/monitor.hpp c042bc1af31aedf7d2991741d3f8cb70ef353b40
> src/slave/monitor.cpp 1c02986e22bc1dcbc2f07de546bf865d34c41c89
> src/slave/slave.hpp 01b80dfc1dd55edd6d2f722ff1d4f1bf4d96f28e
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
>
> Diff: https://reviews.apache.org/r/18785/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>