You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/03/01 05:33:42 UTC
Re: Review Request 44180: Fixes LENS UI module after API contracts
change.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44180/#review121387
-----------------------------------------------------------
Ship it!
Changes look fine to me.
- Amareshwari Sriramadasu
On Feb. 29, 2016, 8:18 p.m., Ankeet Maini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44180/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 8:18 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Deepak Barr, and Rajat Khandelwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes LENS UI module after API contracts change.
>
>
> Diffs
> -----
>
> lens-ui/app/actions/AdhocQueryActions.js 284c781
> lens-ui/app/adapters/AdhocQueryAdapter.js 376068b
> lens-ui/app/adapters/AuthenticationAdapter.js 26a35f3
> lens-ui/app/adapters/BaseAdapter.js 634b974
> lens-ui/app/components/CubeSchemaComponent.js c56cb15
> lens-ui/app/components/QueryDetailResultComponent.js 096adde
> lens-ui/app/components/QueryParamRowComponent.js 89c8a8e
> lens-ui/app/components/TableSchemaComponent.js 7abab95
> lens-ui/app/components/TableTreeComponent.js 799dc9f
> lens-ui/app/stores/AdhocQueryStore.js 3f880bf
> lens-ui/app/stores/CubeStore.js 09b469f
> lens-ui/app/stores/DatabaseStore.js 79894cf
> lens-ui/app/stores/TableStore.js 5ef84fa
> lens-ui/app/stores/UserStore.js ee5506f
> lens-ui/config.json 3316bf6
> lens-ui/package.json b21302b
>
> Diff: https://reviews.apache.org/r/44180/diff/
>
>
> Testing
> -------
>
> UI looks good with this. Saved Query module needs to be tested, along with in-memory result mode. This diff is w.r.t to current-release-line branch.
>
>
> Thanks,
>
> Ankeet Maini
>
>