You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/17 14:21:39 UTC
[GitHub] [camel] orpiske opened a new pull request #7217: CAMEL-17762: improve the log message to include more information on failure
orpiske opened a new pull request #7217:
URL: https://github.com/apache/camel/pull/7217
I was going to fix a typo on the log message and thought about extending the error message to give more details.
Any thoughts?
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske closed pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske closed pull request #7217:
URL: https://github.com/apache/camel/pull/7217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1071132096
In what circumstance can that onFailure be called? Is it when failing to update the offset itself in some storage, or is it for example when a camel exchange is failed during routing or what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1070964552
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1070964552
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske closed pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske closed pull request #7217:
URL: https://github.com/apache/camel/pull/7217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1072123766
Ah okay so maybe we can regard the resume offset as a kind of transaction and if we look at the TX error handler then it has a rollbackLoggingLevel you can configure
https://github.com/apache/camel/blob/028a6b8cdc86b39d3a11dfbf7f5aa4ab96b3cce0/components/camel-spring/src/main/java/org/apache/camel/spring/spi/TransactionErrorHandlerBuilder.java#L40
Which logs like this (without stacktrace)
https://github.com/apache/camel/blob/743d226a07b6926a4935d772b19f65c0e71a69a7/components/camel-spring/src/main/java/org/apache/camel/spring/spi/TransactionErrorHandler.java#L283
As regular Camel error handler does the error handling / logging so you can see the stacktrace there.
If there is stacktrace then it would likely be duplicated and can become very verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1072433633
Closing. TBI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1071148143
> In what circumstance can that onFailure be called? Is it when failing to update the offset itself in some storage, or is it for example when a camel exchange is failed during routing or what?
I think this will happen primarily when an exchange is failing during routing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1071132096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1070964193
@davsclaus @oscerd FYI ... please let me know if you think this is going to be overly verbose (it wasn't on my current test, though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1070964193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7217: CAMEL-17762: improve the log message to include more information on failure
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #7217:
URL: https://github.com/apache/camel/pull/7217#issuecomment-1072433314
> Ah okay so maybe we can regard the resume offset as a kind of transaction and if we look at the TX error handler then it has a rollbackLoggingLevel you can configure
>
> https://github.com/apache/camel/blob/028a6b8cdc86b39d3a11dfbf7f5aa4ab96b3cce0/components/camel-spring/src/main/java/org/apache/camel/spring/spi/TransactionErrorHandlerBuilder.java#L40
>
> Which logs like this (without stacktrace)
>
> https://github.com/apache/camel/blob/743d226a07b6926a4935d772b19f65c0e71a69a7/components/camel-spring/src/main/java/org/apache/camel/spring/spi/TransactionErrorHandler.java#L283
>
> As regular Camel error handler does the error handling / logging so you can see the stacktrace there. If there is stacktrace then it would likely be duplicated and can become very verbose.
Cool, thanks Claus. I think this will do the trick and I'll take a closer look at it. I'll close this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org