You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2016/02/29 16:57:38 UTC
[GitHub] couchdb-fauxton pull request: Add pull request template
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/656
Add pull request template
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-fauxton github-pull-request-template
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/656.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #656
----
commit 20e2498d734573de92aa303f91112bd31d051d82
Author: Alexander Shorin <kx...@apache.org>
Date: 2016-02-29T15:55:27Z
Add pull request template
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #656: Add pull request template
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#discussion_r105115305
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,37 @@
+<!-- Thank you for your contribution!
+
+ Please file this form by replacing markdown commentary
+ tags with the text. If section needs in no action - remove it.
+
+ Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
+ of code collaboration. Positive feedback provides by +1 from committers
+ while negative by -1. The -1 also means veto and need to be addressed
+ to find the consensus. Once there are no objections, PR could be merged.
+
+ See: http://couchdb.apache.org/bylaws.html#decisions for more info -->
+
+## Overview
+
+<!-- Please give a short brief for the pull request,
+ what problem it solves or how it makes things better. -->
+
+## Testing recommendations
+
+<!-- Describe how we can test your changes. -->
+
+## Screenshot
+
+<!-- If visual or design changes were made, please provide the screenshots
+ of how it was and how it looks now in the way to easy detect the positive
+ improvements. -->
+
+## JIRA issue number
--- End diff --
Yes it is. Just waiting for this ticket https://issues.apache.org/jira/browse/INFRA-13627 for it to be enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #656: Add pull request template
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#discussion_r105119372
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,37 @@
+<!-- Thank you for your contribution!
+
+ Please file this form by replacing markdown commentary
+ tags with the text. If section needs in no action - remove it.
+
+ Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
+ of code collaboration. Positive feedback provides by +1 from committers
+ while negative by -1. The -1 also means veto and need to be addressed
+ to find the consensus. Once there are no objections, PR could be merged.
+
+ See: http://couchdb.apache.org/bylaws.html#decisions for more info -->
+
+## Overview
+
+<!-- Please give a short brief for the pull request,
+ what problem it solves or how it makes things better. -->
+
+## Testing recommendations
+
+<!-- Describe how we can test your changes. -->
+
+## Screenshot
+
+<!-- If visual or design changes were made, please provide the screenshots
+ of how it was and how it looks now in the way to easy detect the positive
+ improvements. -->
+
+## JIRA issue number
--- End diff --
Cool!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add pull request template
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#issuecomment-190920635
Hm...I got your idea. Indeed, some stuff worth to put in Contributing (same RTC policy and else). The other bits are a helping reminder what to not forget to do since CONTRIBUTING file is a thing that will be read only few times when you make a first PR. If CONTRIBUTING content get changed, you may never know about. It's easy to forget some details after all.
I'll rethink this PR tomorrow. Thanks for the feedback! (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add pull request template
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#issuecomment-190917050
Oh sorry, perhaps I misunderstood? That doc has a section about `Commit messages should follow the following style:` with an example of what the commit should contain. Doesn't this PR contain different (better) content about what should be in the commit/PR message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #656: Add pull request template
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#discussion_r105106053
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,37 @@
+<!-- Thank you for your contribution!
+
+ Please file this form by replacing markdown commentary
+ tags with the text. If section needs in no action - remove it.
+
+ Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
+ of code collaboration. Positive feedback provides by +1 from committers
+ while negative by -1. The -1 also means veto and need to be addressed
+ to find the consensus. Once there are no objections, PR could be merged.
+
+ See: http://couchdb.apache.org/bylaws.html#decisions for more info -->
+
+## Overview
+
+<!-- Please give a short brief for the pull request,
+ what problem it solves or how it makes things better. -->
+
+## Testing recommendations
+
+<!-- Describe how we can test your changes. -->
+
+## Screenshot
+
+<!-- If visual or design changes were made, please provide the screenshots
+ of how it was and how it looks now in the way to easy detect the positive
+ improvements. -->
+
+## JIRA issue number
--- End diff --
Is that legal now? And I don't see issues tab around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add pull request template
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#issuecomment-190897200
Nice! Could we also update this file to mention this doc? https://github.com/apache/couchdb-fauxton/blob/master/CONTRIBUTING.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add pull request template
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#issuecomment-190898878
How to update? Github already provides a link to CONTRIBUTING within the notice block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #656: Add pull request template
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/656#discussion_r105104656
--- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,37 @@
+<!-- Thank you for your contribution!
+
+ Please file this form by replacing markdown commentary
+ tags with the text. If section needs in no action - remove it.
+
+ Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
+ of code collaboration. Positive feedback provides by +1 from committers
+ while negative by -1. The -1 also means veto and need to be addressed
+ to find the consensus. Once there are no objections, PR could be merged.
+
+ See: http://couchdb.apache.org/bylaws.html#decisions for more info -->
+
+## Overview
+
+<!-- Please give a short brief for the pull request,
+ what problem it solves or how it makes things better. -->
+
+## Testing recommendations
+
+<!-- Describe how we can test your changes. -->
+
+## Screenshot
+
+<!-- If visual or design changes were made, please provide the screenshots
+ of how it was and how it looks now in the way to easy detect the positive
+ improvements. -->
+
+## JIRA issue number
--- End diff --
We going to use Github issues now. Could you change this to Github issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---