You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2008/09/05 01:15:44 UTC

[jira] Created: (CXF-1783) Refactor JMS transport second step (patch included)

Refactor JMS transport second step (patch included)  
-----------------------------------------------------

                 Key: CXF-1783
                 URL: https://issues.apache.org/jira/browse/CXF-1783
             Project: CXF
          Issue Type: Improvement
          Components: Transports
    Affects Versions: 2.1.2
            Reporter: Christian Schneider
             Fix For: 2.1.3


I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
The refactoring should not change the functionality.

SessionFactory and PooledSession:
The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.

Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.

JMSOutputStream:
Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.

JMSListenerThread and JMSExecutor:
Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.

JMSConduit:
Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines

JMSDestination:
Same as with JMSConduit. 550 lines => 420 lines

Tests:
All tests work

- Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
- AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
- JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628539#action_12628539 ] 

Willem Jiang commented on CXF-1783:
-----------------------------------

Just for a comment for AbstractJMSTest setInMessage:
It should  logicaly calls setOutMessage for the conduit sendOutMessage.
Since we do not take the message from the exchange , it is harmless to set the inMessage or outMessage with the send out message to the exchange.



> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628566#action_12628566 ] 

Willem Jiang commented on CXF-1783:
-----------------------------------

applied patch into the trunk 
 http://svn.apache.org/viewvc?rev=692329&view=rev
and 2.1.x 
 http://svn.apache.org/viewvc?rev=692344&view=rev



> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider updated CXF-1783:
-------------------------------------

    Attachment: CXF-1783-refactor-jms-2.patch

Patch for the issue

> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628565#action_12628565 ] 

Christian Schneider commented on CXF-1783:
------------------------------------------

I guessed that it just did not matter with the old code. But in the refectoring I use the Exchange so at this time it became important. I hope it is safe to use the exchange.getOutMessage.

> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-1783.
------------------------------

    Resolution: Fixed

Marking resolved since patch is applied.


> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628585#action_12628585 ] 

Willem Jiang commented on CXF-1783:
-----------------------------------

also applied this patch to 2.0.x branch
 http://svn.apache.org/viewvc?rev=692371&view=rev

> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider closed CXF-1783.
------------------------------------


Ok .. will create a new issue for the next part

> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider updated CXF-1783:
-------------------------------------

    Fix Version/s: 2.0.9

> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.0.9, 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (CXF-1783) Refactor JMS transport second step (patch included)

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang reassigned CXF-1783:
---------------------------------

    Assignee: Willem Jiang

> Refactor JMS transport second step (patch included)  
> -----------------------------------------------------
>
>                 Key: CXF-1783
>                 URL: https://issues.apache.org/jira/browse/CXF-1783
>             Project: CXF
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 2.1.2
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.1.3
>
>         Attachments: CXF-1783-refactor-jms-2.patch
>
>
> I have refactored several parts of the JMS Transport to make it easier to understand and to help preparing for a move to the spring jms classes.
> The refactoring should not change the functionality.
> SessionFactory and PooledSession:
> The sessionfactory had two different caches and a lot of redundant code. I have now only one cache left that starts send only. A consumer is then added when the first client needs it. The lines of code of SessionFactory are reduced from 450 to 300.
> Functionality of JMSProviderHub is splitted between SessionFactory and JMSUtils
> The connect method now does not need a callback anymore. So the interface JMSOnConnectCallback is deleted.
> JMSOutputStream:
> Extracted the class from JMSDestination and JMSConduit. They both use the same JMSOutputStream now. A new interface JMSExchangeSender calls back into JMSConduit or JMSDestination.
> JMSListenerThread and JMSExecutor:
> Extracted JMSListenerThread from JMSDestination. So the complete JMS listen functionality is factored out. This means it will be easier to port to Spring MessageListenerContainer. JMSListener does not use the Session pool anymore as it does not need pooling anyway.
> JMSConduit:
> Made the program flow easier again and documented where the flow of operation is not easy to understand. 420 lines => 290 lines
> JMSDestination:
> Same as with JMSConduit. 550 lines => 420 lines
> Tests:
> All tests work
> - Cut most of PooledSessionTest as it does not apply anymore. Have not written a new test yet. But I think it is mostly implicitly tested by other tests
> - AbstractJMSTests replaced setInMessage with setOutMessage. I think this was wrong before. Please review
> - JMSDestinationTest added a second message send as I had an issue with a closed session after first send because of an error in the SessionFactory. This is to avoid regression

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.