You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 22:18:20 UTC
[PR] fix(settings): mirror the server's curated model list in the fallback [rocketmq-dashboard]
unbridled-41 opened a new pull request, #6013:
URL: https://github.com/apache/rocketmq-dashboard/pull/6013
### Which Issue(s) This PR Fixes
Fixes #6012
### Problem / Evidence
`web/src/pages/studio/llmModelOptions.ts` vs `LlmConfigService.PROVIDER_MODELS` (the source of truth for `GET /llm/models` and the home-page picker):
```
LlmSettings: mirrors the server curated model list per provider
AssertionError: expected [ 'qwen3.8-max', ... ] (7) to deeply equal [...] (12)
```
### Root cause / Fix
Two sources of truth for one fact; the frontend mirror was not updated when the server's curated set grew (and gained gemma2 on ollama in the other direction). Align the fallback with the server list and pin both entries in the existing test.
### Priority and scoring
**PRIORITY 52** - impact 18/40 (five models unreachable in the settings dialog), blast radius 10/20 (the AI settings dialog and the composer's model list), reproducibility 18/20 (pinned by the new test), maintenance value 6/20. **FIX_CONFIDENCE 88**.
### Tests
`cd web && npx vitest run src/pages/studio/__tests__/LlmSettings.test.ts` -> `Tests 5 passed`; the new case fails before the change and passes after it; `npx eslint` and `npx tsc -b` are clean.
### Risk
The fallback list is longer for tongyi and one entry shorter for ollama; the endpoint's answer still wins when it succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): mirror the server's curated model list in the fallback [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6013: fix(settings): mirror the server's curated model list in the fallback
URL: https://github.com/apache/rocketmq-dashboard/pull/6013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): mirror the server's curated model list in the fallback [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #6013:
URL: https://github.com/apache/rocketmq-dashboard/pull/6013#issuecomment-6090219050
### CI status of this PR
`Backend Tests (Java 21)` — still running at the time of writing; the change-specific commands and their results are in the Tests section of the description.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): mirror the server's curated model list in the fallback [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #6013:
URL: https://github.com/apache/rocketmq-dashboard/pull/6013#issuecomment-6091431461
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `415298cf06`:
| command | exit | result |
| --- | --- | --- |
| `cd web && npx vitest run src/pages/studio/__tests__/LlmSettings.test.ts` | 0 | `Test Files 1 passed (1) · Tests 5 passed (5)` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(settings): mirror the server's curated model list in the fallback [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6013:
URL: https://github.com/apache/rocketmq-dashboard/pull/6013#issuecomment-6120357686
Thanks — this is merged, as part of [`d2f0f762c`](https://github.com/apache/rocketmq-dashboard/commit/d2f0f762cc8e503fe314168e7cb79ef6bf40fab1) on `rocketmq-studio`.
Your change went in together with #6011 and #6015 — all yours, all in the same area — so we folded them into a single commit instead of landing several near-identical entries for the same subsystem. Nothing was dropped.
The commit message calls this one out explicitly:
> #6013 `web/src/pages/studio/llmModelOptions.ts:31-40` had drifted from the server's curated `LlmConfigService.PROVIDER_MODELS` — `tongyi` listed 7 of the 12 ids at `LlmConfigService.java:69-81` and `ollama` listed `gemma2`, which `:82-85` does not serve → the fallback mirrors both lists in server order with a comment naming `PROVIDER_MODELS` as the single source of truth, so `AiAssistantTab.tsx:130` (provider switch) and `:189-190` (first load, or a failed `GET /llm/models`) stop hiding five models the gateway supports and stop offering one that always fails; `openai`, `azure`, `anthropic`, `deepseek` and `bedrock` were already item-for-item equal and are untouched.
Closing as folded, not rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org