[GitHub] [iceberg] szehon-ho commented on pull request #5329: Improve bloom filter test for false positive case

[GitBox <gi...@apache.org>]

szehon-ho commented on PR #5329:
URL: https://github.com/apache/iceberg/pull/5329#issuecomment-1192060669

   While this makes sense, I wonder if its even worth to assert that number of false positives is less than some number?  Each test asserting there's no false negatives may be good enough?
   
   I assume that there is still a failure chance, and it may not really be suitable for unit test to be run each time?  Curious what other parquet or other projects do.  Also wondering what others think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org